Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix TW national_prefix #487

Merged
merged 1 commit into from
Nov 21, 2017
Merged

fix TW national_prefix #487

merged 1 commit into from
Nov 21, 2017

Conversation

swdyh
Copy link
Contributor

@swdyh swdyh commented Nov 21, 2017

TW(Taiwan) national prefix number is 0.
It is also 0 in Google's libphonenumber library.

https://github.com/googlei18n/libphonenumber/blob/master/resources/PhoneNumberMetadata.xml#L23907

line: 23907

    <territory id="TW" countryCode="886" internationalPrefix="0(?:0[25679]|19)" nationalPrefix="0"
               preferredExtnPrefix="#" nationalPrefixFormattingRule="$NP$FG"
               mobileNumberPortableRegion="true">

@rposborne rposborne merged commit 1dea237 into countries:master Nov 21, 2017
@swdyh swdyh deleted the patch-1 branch November 22, 2017 03:08
@rposborne
Copy link
Collaborator

@swdyh 2.1.3 released which includes this change

@swdyh
Copy link
Contributor Author

swdyh commented Dec 27, 2017

@rposborne Thank you. I will try to use It.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swdyh @rposborne