Fix search to work for countries with comma in their name #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using ISO3166::Country.find_country_by_name('Korea, Republic of')
returns nil, since Korea is stored as "Korea (Republic of)".
This change will normalize all the terms that are used to search and
those in the Data.cache.
|
Thank you very much. |
|
Welcome, I'll try to cut a release soon. Ping me again if it's not done by next friday :) |
|
@budmc29 2.1.3 released which includes this change |
|
That's great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using ISO3166::Country.find_country_by_name('Korea, Republic of')
returns nil, since Korea is stored as "Korea (Republic of)".
This change will normalize all the terms that are used to search and
those in the Data.cache.