Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Volume Bar? #40

Closed
Aersaud opened this issue Jan 21, 2019 · 5 comments
Closed

Volume Bar? #40

Aersaud opened this issue Jan 21, 2019 · 5 comments
Labels
enhancement New feature or request

Comments

@Aersaud
Copy link

Aersaud commented Jan 21, 2019

I was testing it out and so far I must say its amazing. One thing I noticed missing is a volume bar.

@rrrnld
Copy link
Owner

rrrnld commented Jan 21, 2019

Thanks for the feedback! It's true that there is no volume bar because I never quite understood the benefit of having one. In general my tracks all have the same gain more or less; when I want to mute the player I either pause or use the "mute tab" functionality in Firefox (which exists in Chrome as well I think). Can you tell me how you use the volume controls in the player itself?

@Aersaud
Copy link
Author

Aersaud commented Jan 21, 2019

Whenever I am playing media in the browser (background music) I usually lower it down while I am playing a game or working. I see a nice spot for where it would work. Would also fill in that gap :P

image

@rrrnld
Copy link
Owner

rrrnld commented Jan 30, 2019

I see. I have to say this is not very high on my list right now but I wouldn't mind if anybody implemented this. ;) I guess the hardest part will be building the UI for the actual volume bar, but even that should be ok.

@rrrnld rrrnld mentioned this issue Feb 20, 2019
@rrrnld
Copy link
Owner

rrrnld commented Feb 20, 2019

So I implemented something, didn't have time to test it much. You can find it either in the pull request above or deployed at https://heyarne.github.io/airsonic-ui.

Let me know if it works!

@rrrnld rrrnld added the enhancement New feature or request label Feb 20, 2019
@rrrnld
Copy link
Owner

rrrnld commented Mar 2, 2019

Branch is merged, closing this for now

@rrrnld rrrnld closed this as completed Mar 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants