Normative: Rename numeric types to match ECMAScript typed arrays #856
Conversation
index.bs
Outdated
| Promise<void> delay(unrestricted double ms); | ||
| Promise<void> delay(unrestricted f64 ms); |
There was a problem hiding this comment.
Note that I had to revert this due to unrestricted f64 currently being a syntax error.
There was a problem hiding this comment.
Would this mean the PR should wait for the parser to be updated first?
There was a problem hiding this comment.
We could probably merge this as‑is, since this PR also defines "aliases" for:
// Not actually implemented using `typedef`s, this is just for illustration:
typedef (i8) byte;
typedef (i16) short;
typedef (i32) long;
typedef (i64) long long;
typedef (u8) octet;
typedef (u16) unsigned short;
typedef (u32) unsigned long;
typedef (u64) unsigned long long;
typedef (f32) float;
typedef (unrestricted f32) unrestricted float;
typedef (f64) double;
typedef (unrestricted f64) unrestricted double;We’d just have to remember to convert unrestricted double to unrestricted f64 once the parser is updated.
There was a problem hiding this comment.
AFAIK an identifier can't contain a whitespace and thus it can't be like typedef (i64) long long;.
There was a problem hiding this comment.
That’s why this isn’t actually implemented using typedefs, that is just for illustration, the actual aliases are defined as:
For legacy compatibility,
byteis to be treated as an alias fori8, similar to:
There was a problem hiding this comment.
Ah, missed that part, sorry 😅
index.bs
Outdated
| Promise<void> validatedDelay(unrestricted double ms); | ||
| Promise<void> validatedDelay(unrestricted f64 ms); |
index.bs
Outdated
| Promise<any> addDelay(Promise<any> promise, unrestricted double ms); | ||
| Promise<any> addDelay(Promise<any> promise, unrestricted f64 ms); |
…ename-numeric-types
ExE-Boss
changed the title
ExE-Boss
changed the title
Since there was support for #843, I decided to go ahead with opening a PR for this.
I decided to go with
i*for signed integers because it’s what browser engines and the Rust programming language use and due to ECMAScript providing implicit support for 32‑bit signed integers using the binary OR operator, but none for unsigned integers:ECMAScript
Arrays also restrict the length to a positive 32‑bit signed integer.Depends on:
unrestrictedkeyword into an extended attribute #857Resolves #843
🔗 PR Preview
Preview | Diff