Rename all legacy extended attributes #870

domenic · 2020-04-08T21:35:45Z

This pull request contains a series of commits that together close #350. I suggest we rebase-merge, instead of squash-merge, to better make the individual changes clear from the history.

I've updated #350 with a list of specifications that use these extended attributes, and will work on corresponding pull requests to them.

Preview | Diff

Part of #350.

Closes #277. This includes renaming the extended attribute, which is part of #350. Also, since we don't anticipate this being used again, we remove the zero-argument form, which has no current users. As a bonus, this removes some leftover references to "constructor extended attributes".

Part of #350.

Part of #350. Also removes some references to usages in other specs that have since been fixed, and removes the discussion of the previous usage of this extended attribute for mixin purposes, as all those usages have migrated.

This groups all the legacy extended attributes under a new section, that follows the general extended attributes section. (It also renames that section from "ECMAScript-specific extended attributes" to "Extended attributes", since we are already in the ECMAScript binding section.) As part of this, it removes all the individual "do not use this" warnings, in favor of a blanket one at the start of the section. Some cases, namely [LegacyFactoryFunction], [LegacyLenientSetter], and [LegacyNamespace], contained advice or background information in those blocks; those have been preserved.

Follows whatwg/webidl#870.

[TreatNullAs=EmptyString] → [LegacyNullToEmptyString] and [Unforgeable] → [LegacyUnforgeable]. Follows whatwg/webidl#870.

Follows whatwg/webidl#870. Additionally, this cross-links all of these extended attributes from their usage sites, since I was updating them anyway.

[TreatNullAs=EmptyString] → [LegacyNullToEmptyString], following whatwg/webidl#870.

[TreatNullAs=EmptyString] → [LegacyNullToEmptyString], per whatwg/webidl#870.

[NoInterfaceObject] → [LegacyNoInterfaceObject]. This follows whatwg/webidl#870.

[NoInterfaceObject] → [LegacyNoInterfaceObject]. This follows whatwg/webidl#870. This also replaces a couple instances of [NoInterfaceObject] with the interface mixin concept, as was previously done in 2df151b and a6f9909.

domenic · 2020-04-08T22:29:36Z

All specs that use these now have pull requests to update.

marcoscaceres · 2020-04-09T05:24:15Z

Please make sure ReSpec and BikeShed are not using these also before merging... cc @sidvishnoi, just in case.

annevk · 2020-04-09T07:12:23Z

Do you think we can still switch to "builtin" everywhere? It seems that's what ECMAScript uses and I kind prefer to use the hyphen-less version whenever possible. I think it's mostly DOM and HTML, right? I could PR those.

domenic · 2020-04-09T13:39:05Z

I'm confused, in #350 you said we should switch to BuiltIn, which is what I did here. Which one do you want?

annevk · 2020-04-09T15:20:02Z

So earlier today I looked at ECMAScript again and found CreateBuiltinFunction. However, I now see it also has built-in, builtinTag, RegExpBuiltinExec, ... Sigh.

domenic · 2020-04-09T17:55:11Z

I was kind of under the impression that built-in was the adjective and builtin was the noun, but I can find no evidence for this on the internet.

annevk

I did not read through everything in detail, but I didn't spot any obvious mistakes either. Unfortunately TC39 didn't really settle the builtin thing yet so I guess we'll go with internal consistency for now.

Follows whatwg/webidl#870. Additionally, this cross-links all of these extended attributes from their usage sites, since I was updating them anyway.

[TreatNullAs=EmptyString] → [LegacyNullToEmptyString] and [Unforgeable] → [LegacyUnforgeable]. Follows whatwg/webidl#870.

[TreatNullAs=EmptyString] → [LegacyNullToEmptyString], following whatwg/webidl#870.

Fixes #57

domenic · 2020-04-20T20:02:36Z

Bugs:

and @saschanaz seems to be on top of things for webidl2.js.

Follows whatwg/webidl#870.

* Update for Web IDL extended attribute changes [NoInterfaceObject] → [LegacyNoInterfaceObject]. This follows whatwg/webidl#870. This also replaces a couple instances of [NoInterfaceObject] with the interface mixin concept, as was previously done in 2df151b and a6f9909.

[TreatNullAs=EmptyString] → [LegacyNullToEmptyString], per whatwg/webidl#870.

[TreatNullAs=EmptyString] → [LegacyNullToEmptyString] and [Unforgeable] → [LegacyUnforgeable]. Follows whatwg/webidl#870.

`[Unforgeable]` was renamed to `[LegacyUnforgeable]` in April of 2020: whatwg/webidl#870

whatwg/webidl#870

domenic added 9 commits April 8, 2020 16:50

Rename [LenientSetter] to [LegacyLenientSetter]

a515499

Part of #350.

Rename [LenientThis] to [LegacyLenientThis]

2837492

Part of #350.

Rename [OverrideBuiltins] to [LegacyOverrideBuiltIns]

fdb05ef

Part of #350.

Rename [TreatNonObjectAsNull] to [LegacyTreatNonObjectAsNull]

ba0fcdb

Part of #350.

Rename [Unforgeable] to [LegacyUnforgeable]

92f1e2f

Part of #350.

Rename [TreatNullAs=EmptyString] to [LegacyNullToEmptyString]

2e10ee3

Part of #350.

Rename [NoInterfaceObject] to [LegacyNoInterfaceObject]

62963e8

Part of #350. Also removes some references to usages in other specs that have since been fixed, and removes the discussion of the previous usage of this extended attribute for mixin purposes, as all those usages have migrated.

domenic added a commit to whatwg/fullscreen that referenced this pull request Apr 8, 2020

Align with Web IDL change: [LenientSetter] → [LegacyLenientSetter]

b631fd9

Follows whatwg/webidl#870.

domenic mentioned this pull request Apr 8, 2020

Align with Web IDL change: [LenientSetter] → [LegacyLenientSetter] whatwg/fullscreen#169

Merged

domenic added a commit to whatwg/dom that referenced this pull request Apr 8, 2020

Align with Web IDL extended attribute changes

c4fb6e5

[TreatNullAs=EmptyString] → [LegacyNullToEmptyString] and [Unforgeable] → [LegacyUnforgeable]. Follows whatwg/webidl#870.

domenic mentioned this pull request Apr 8, 2020

Align with Web IDL extended attribute changes whatwg/dom#856

Merged

domenic added a commit to whatwg/html that referenced this pull request Apr 8, 2020

Align with Web IDL extended attribute changes

c396b8e

Follows whatwg/webidl#870. Additionally, this cross-links all of these extended attributes from their usage sites, since I was updating them anyway.

domenic mentioned this pull request Apr 8, 2020

Align with Web IDL extended attribute changes whatwg/html#5450

Merged

domenic added a commit to w3c/DOM-Parsing that referenced this pull request Apr 8, 2020

Update for Web IDL extended attribute changes

8098fac

[TreatNullAs=EmptyString] → [LegacyNullToEmptyString], following whatwg/webidl#870.

domenic mentioned this pull request Apr 8, 2020

Update for Web IDL extended attribute changes w3c/DOM-Parsing#62

Merged

domenic added a commit to domenic/csswg-drafts that referenced this pull request Apr 8, 2020

[cssom-1] Follow Web IDL extended attribute changes

cdea08f

[TreatNullAs=EmptyString] → [LegacyNullToEmptyString], per whatwg/webidl#870.

domenic mentioned this pull request Apr 8, 2020

[cssom-1] Follow Web IDL extended attribute changes w3c/csswg-drafts#4930

Merged

domenic added a commit to domenic/WebGL that referenced this pull request Apr 8, 2020

Update for Web IDL extended attribute changes

0c6a339

[NoInterfaceObject] → [LegacyNoInterfaceObject]. This follows whatwg/webidl#870.

domenic mentioned this pull request Apr 8, 2020

Update for Web IDL extended attribute changes KhronosGroup/WebGL#3049

Merged

annevk mentioned this pull request Apr 14, 2020

Editorial: built-in or builtin tc39/ecma262#1947

Open

annevk approved these changes Apr 20, 2020

View reviewed changes

domenic deleted the legacyxattrs branch April 20, 2020 17:26

domenic added a commit to whatwg/html that referenced this pull request Apr 20, 2020

Align with Web IDL extended attribute changes

5f22f61

Follows whatwg/webidl#870. Additionally, this cross-links all of these extended attributes from their usage sites, since I was updating them anyway.

saschanaz mentioned this pull request Apr 20, 2020

Implement validation/autofix for renamed legacy extended attributes w3c/webidl2.js#463

Closed

annevk pushed a commit to whatwg/dom that referenced this pull request Apr 20, 2020

Align with Web IDL extended attribute changes

f4d4f3b

[TreatNullAs=EmptyString] → [LegacyNullToEmptyString] and [Unforgeable] → [LegacyUnforgeable]. Follows whatwg/webidl#870.

domenic added a commit to w3c/DOM-Parsing that referenced this pull request Apr 20, 2020

Update for Web IDL extended attribute changes

95b9ffb

[TreatNullAs=EmptyString] → [LegacyNullToEmptyString], following whatwg/webidl#870.

plinss added a commit to plinss/widlparser that referenced this pull request Apr 20, 2020

Update legacy extended attribute names per whatwg/webidl#870

e728939

Fixes #57

domenic added a commit to whatwg/fullscreen that referenced this pull request Apr 20, 2020

Align with Web IDL change: [LenientSetter] → [LegacyLenientSetter]

693db15

Follows whatwg/webidl#870.

stephenmcgruer mentioned this pull request Apr 21, 2020

idlharness.js does not handle newly renamed extended attributes web-platform-tests/wpt#23148

Closed

sidvishnoi mentioned this pull request Apr 22, 2020

test(core/webidl): remove legacy TreatNullAs speced/respec#2851

Merged

ExE-Boss mentioned this pull request Apr 22, 2020

Editorial: Add missing oldids attribute to [LegacyFactoryFunction] #872

Merged

tabatkins pushed a commit to w3c/csswg-drafts that referenced this pull request Apr 23, 2020

[cssom-1] Follow Web IDL extended attribute changes (#4930)

272f1c0

[TreatNullAs=EmptyString] → [LegacyNullToEmptyString], per whatwg/webidl#870.

mfreed7 pushed a commit to mfreed7/dom that referenced this pull request Apr 27, 2020

Align with Web IDL extended attribute changes

5992029

[TreatNullAs=EmptyString] → [LegacyNullToEmptyString] and [Unforgeable] → [LegacyUnforgeable]. Follows whatwg/webidl#870.

zcorpan mentioned this pull request Jul 22, 2020

Errors in IDL Maps4HTML/MapML-Specification#90

Closed

jugglinmike added a commit to bocoup/webappsec-trusted-types that referenced this pull request Aug 26, 2020

Update WebIDL attribute name

e8cba00

`[Unforgeable]` was renamed to `[LegacyUnforgeable]` in April of 2020: whatwg/webidl#870

jugglinmike mentioned this pull request Aug 26, 2020

Update WebIDL attribute name w3c/trusted-types#289

Merged

koto pushed a commit to w3c/trusted-types that referenced this pull request Aug 27, 2020

Update WebIDL attribute name (#289)

4feec85

`[Unforgeable]` was renamed to `[LegacyUnforgeable]` in April of 2020: whatwg/webidl#870

sagudev added a commit to sagudev/servo that referenced this pull request Feb 19, 2023

Rename legacy extended attributes in webidls

55dac83

whatwg/webidl#870

nektro mentioned this pull request Jun 29, 2024

test clarification: multiple 'valid' syntax cases use legacy extended attributes w3c/webidl2.js#787

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rename all legacy extended attributes #870

Rename all legacy extended attributes #870

domenic commented Apr 8, 2020 •

edited by pr-preview bot

Loading

domenic commented Apr 8, 2020

marcoscaceres commented Apr 9, 2020 •

edited

Loading

annevk commented Apr 9, 2020

domenic commented Apr 9, 2020

annevk commented Apr 9, 2020

domenic commented Apr 9, 2020

annevk left a comment

domenic commented Apr 20, 2020 •

edited

Loading

Rename all legacy extended attributes #870

Rename all legacy extended attributes #870

Conversation

domenic commented Apr 8, 2020 • edited by pr-preview bot Loading

domenic commented Apr 8, 2020

marcoscaceres commented Apr 9, 2020 • edited Loading

annevk commented Apr 9, 2020

domenic commented Apr 9, 2020

annevk commented Apr 9, 2020

domenic commented Apr 9, 2020

annevk left a comment

Choose a reason for hiding this comment

domenic commented Apr 20, 2020 • edited Loading

domenic commented Apr 8, 2020 •

edited by pr-preview bot

Loading

marcoscaceres commented Apr 9, 2020 •

edited

Loading

domenic commented Apr 20, 2020 •

edited

Loading