Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Meta: fix linking to "incumbent settings object" #988

Merged
merged 1 commit into from
Jun 3, 2021
Merged

Meta: fix linking to "incumbent settings object" #988

merged 1 commit into from
Jun 3, 2021

Conversation

domenic
Copy link
Member

@domenic domenic commented Jun 2, 2021

Although it was un-exported from HTML recently, Web IDL is one of the very few specs which has legitimate reason to link to it.

@domenic
Meta: fix linking to "incumbent settings object"
7d9836e 
Although it was un-exported from HTML recently, Web IDL is one of the very few specs which has legitimate reason to link to it.
annevk
annevk approved these changes Jun 3, 2021
View reviewed changes
Copy link
Member

@annevk annevk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add some kind of source comment about this? This kinda makes me think we should still rename the term as not exporting it might not dissuade folks from not using it.

@domenic
Copy link
Member Author

domenic commented Jun 3, 2021

I'm hopeful it's clear enough that Web IDL is special... we should keep our eyes peeled though.

@domenic domenic merged commit 9d43a5d into master Jun 3, 2021
@annevk annevk deleted the fix-incumbent-build branch June 3, 2021 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@domenic @annevk