Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming the video #46

Closed
heysagnik opened this issue Oct 12, 2022 · 3 comments
Closed

Naming the video #46

heysagnik opened this issue Oct 12, 2022 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest hacktoberfest-accepted help wanted Extra attention is needed

Comments

@heysagnik
Copy link
Owner

Describe the bug
If some one by mistake input a dot or any punctuation mark as the name then it should ask for a new name, otherwise after the user downloads the video , he won't be able to open the file.

To Reproduce
Steps to reproduce the behavior:

  1. Go to the website
  2. Name the video to 'hello.html'
  3. Record randomly and download it
  4. See error

Expected behavior
It should show a warning message when the users save by invalid names

Desktop (please complete the following information):

  • OS: Windows 11
  • Browser : chrome
  • Version : latest
@heysagnik heysagnik added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest hacktoberfest-accepted labels Oct 12, 2022
@heysagnik
Copy link
Owner Author

@Villain45 please can you fix it? After merging a user reached out to me with this issue.

@pathakharsh123
Copy link

pathakharsh123 commented Oct 12, 2022

Sir can I take this issue ?

@Villain45
Copy link
Collaborator

@heysagnik Yeah will do
But I guess it will not give any error, the downloaded file is easily opened and can be played since it will again concatenated with the extension

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest hacktoberfest-accepted help wanted Extra attention is needed
Projects
No open projects
Status: Done
Development

No branches or pull requests

3 participants