Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Strict checking for conversion of strings to DateTime objects #5
This PR compensates for changes in DateTime::Format::Strptime. That module now allows minutes to be omitted from the timezone, and per default ignores trailing garbage. Unfortunately, this makes a test with an invalid time stamp run without throwing up - which it should.
As of DateTime::Format::Strptime version 1.71, there's a "strict" parameter which does no longer allow trailing garbage. This is now set, the version requirement added to the code.
I have not yet committed stuff for the Changes file because I doubt this can be automatically merged with the other PR coming soon.
I just noted that the CI tests croak because dzil complains about a duplicate LICENSE file. You have one in your code base, and dzil tries to create its own. Both license files are fundamentally different. I guess dist.ini would need some tuning, but need your advice in which direction.
I can reproduce that:
[DZ] attempt to add LICENSE multiple times; added by: filename set by GatherDir (Dist::Zilla::Plugin::GatherDir line 225); encoded_content added by @Starter/GatherDir (Dist::Zilla::Plugin::GatherDir line 226); content added by @Starter/License (Dist::Zilla::Plugin::License line 37)
I have removed the LICENSE file in the repository, but also added a COPYRIGHT AND LICENSE section in your main module to satisfy CPANTS kwalitee check. I've also added to the Changes file.
With these changes in place, the PR #6 is no longer needed. I did not do the same changes for that PR.
Looks as if the distribution now passes the CI test. Cheers!