Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Lenster redesign #539

Closed
29 tasks done
bigint opened this issue Aug 25, 2022 · 12 comments
Closed
29 tasks done

🎨 Lenster redesign #539

bigint opened this issue Aug 25, 2022 · 12 comments
Assignees

Comments

@bigint
Copy link
Member

bigint commented Aug 25, 2022

Migration Basics

  1. Chore Documentation
    bigint
  2. bigint
  3. bigint
  4. bigint

Publication Component

  1. bigint
  2. bigint
  3. bigint

Search

  1. bigint

Discoverability

  1. bigint
@bigint bigint added this to the v1.0.4 milestone Aug 25, 2022
@bigint bigint pinned this issue Aug 25, 2022
@bigint bigint changed the title Lenster redesign 🎨 Lenster redesign Aug 26, 2022
@vinliao
Copy link

vinliao commented Aug 27, 2022

Figma (or screenshot) required, or just PR?

@bigint
Copy link
Member Author

bigint commented Aug 27, 2022

@vinliao we dont have Figma yet, but its good to have 🙇🏼

@thethemit
Copy link

what do you think, do you agree if the lens adds an auto translate feature on post or comment?

mybe and i think can help for user if problem to meaning someone say post or comment

@GrgW
Copy link
Contributor

GrgW commented Aug 27, 2022

Just a comment:

Would be nice if this Discoverability project could split the work into [1] spec'ing out an interface and [2] providing an (initial) implementation. This would lay some groundwork for Lens client apps to support pluggable modules. It doesen't matter if the interface [1] still moves around a bit, objective it to set a precedent.

Lenster could then move towards supporting an ecosystem of modules from which users can self-assemble these components e.g. feed that excludes 'gm' posts, a feed that uses AI to exclude repetitive GIFs posts, recommend users that comment more than they post,....

@vinliao
Copy link

vinliao commented Aug 29, 2022

Agree with @GrgW on separating design spec (Figma, or at least screenshot) with implementation. I've seen front-end projects where randos create a PR with bad design and the the maintainer merged it because: "Well, this person has worked hard, and rejecting the PR wouldn't be a polite move." I don't think that's a good position to be in.

@GrgW
Copy link
Contributor

GrgW commented Aug 29, 2022

@vinliao agree re UI design spec.

Just to clarify - my comment was about splitting the module code i/f and the code implementation of that i/f. This allows for future implementations of that interface to be developed and then integrated into Lenster with minimal effort.

@elie222
Copy link

elie222 commented Aug 30, 2022

Agree with @GrgW on separating design spec (Figma, or at least screenshot) with implementation. I've seen front-end projects where randos create a PR with bad design and the the maintainer merged it because: "Well, this person has worked hard, and rejecting the PR wouldn't be a polite move." I don't think that's a good position to be in.

Agreed. Would be a lot better to split this task into design and development. They're usually done by two different sets of people.
The design for Lenster looks pretty good already so it should be definitely be approved as a design first, and only passed off to devs after the Figma has been okayed.

@bigint
Copy link
Member Author

bigint commented Aug 30, 2022

Agreed @elie222, I'll update the issue description and split both task and have subtasks for it 🙇🏼

@theolawalemi
Copy link

@bigint I know this would be so challenging but at the same time, it’s going to be fun to participate.
Time to give it a shot. ❤️

@bigint
Copy link
Member Author

bigint commented Jun 4, 2023

Creating new issue for this

@bigint bigint closed this as completed Jun 4, 2023
Copy link
Contributor

github-actions bot commented Jan 7, 2024

This issue has been locked since it has been closed for more than 10 days.

If you found a concrete bug or regression related to it, please open a new bug report.

1 similar comment
Copy link
Contributor

github-actions bot commented Jan 7, 2024

This issue has been locked since it has been closed for more than 10 days.

If you found a concrete bug or regression related to it, please open a new bug report.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

7 participants