Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show post thread with OG post #1034

Merged
merged 7 commits into from
Nov 3, 2022
Merged

feat: show post thread with OG post #1034

merged 7 commits into from
Nov 3, 2022

Conversation

sasicodes
Copy link
Contributor

@sasicodes sasicodes commented Oct 31, 2022

What does this PR do?

image

Fixes #956

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Enhancement (non-breaking small changes to existing functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How should this be tested?

  • Test A
  • Test B

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't performed a self-review of my own code and corrected any misspellings
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

@vercel
Copy link

vercel bot commented Oct 31, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
lenster ✅ Ready (Inspect) Visit Preview Nov 2, 2022 at 10:58AM (UTC)

@sasicodes sasicodes changed the title feat: show post thread feat: show post thread with og Oct 31, 2022
@vercel vercel bot temporarily deployed to Preview October 31, 2022 12:39 Inactive
@sasicodes sasicodes self-assigned this Oct 31, 2022
@sasicodes sasicodes changed the title feat: show post thread with og feat: show post thread with OG post Oct 31, 2022
@sasicodes sasicodes requested review from bigint and removed request for bigint October 31, 2022 12:41
@sasicodes sasicodes added WIP and removed WIP labels Oct 31, 2022
@vercel vercel bot temporarily deployed to Preview November 2, 2022 08:18 Inactive
@sasicodes sasicodes marked this pull request as ready for review November 2, 2022 08:28
@vercel vercel bot temporarily deployed to Preview November 2, 2022 08:29 Inactive
@vercel vercel bot temporarily deployed to Preview November 2, 2022 09:27 Inactive
@vercel vercel bot temporarily deployed to Preview November 2, 2022 09:50 Inactive
@vercel vercel bot temporarily deployed to Preview November 2, 2022 09:53 Inactive
@vercel vercel bot temporarily deployed to Preview November 2, 2022 10:58 Inactive
@bigint bigint merged commit 9d80996 into main Nov 3, 2022
@bigint bigint deleted the threads-root branch November 3, 2022 05:28
@sasicodes sasicodes restored the threads-root branch November 3, 2022 08:23
sasicodes added a commit that referenced this pull request Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timeline v2 - Thread with OP post
2 participants