Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeline v2 - Thread with OP post #956

Closed
sasicodes opened this issue Oct 27, 2022 · 7 comments · Fixed by #1034
Closed

Timeline v2 - Thread with OP post #956

sasicodes opened this issue Oct 27, 2022 · 7 comments · Fixed by #1034
Assignees
@sasicodes

Comments

@sasicodes
Copy link
Contributor

sasicodes commented Oct 27, 2022 •
edited
Loading

The middle comment in thread is missing now in timeline v2.

image
@sasicodes sasicodes self-assigned this Oct 27, 2022
@sasicodes sasicodes mentioned this issue Oct 27, 2022
Closed
7 tasks
@sasicodes sasicodes changed the title Timeline v2 - Thread comments with OP post Timeline v2 - Thread with OP post Oct 31, 2022
@sasicodes sasicodes mentioned this issue Oct 31, 2022
Merged
7 tasks
@sasicodes sasicodes reopened this Nov 3, 2022
@sasicodes sasicodes mentioned this issue Nov 3, 2022
Closed
7 tasks
@0xchetan
Copy link

0xchetan commented Dec 4, 2022

@bigint would it be possible to elaborate on this issue?

@sasicodes
Copy link
Contributor Author

sasicodes commented Dec 5, 2022 •
edited
Loading

@0xchetan if a user visits any comment details, we show only the comment and its comments.

We should load the original post on top of the comment and it should only be visible on scrolling up. (check bird app)

@0xchetan
Copy link

@sasicodes @bigint do we have an existing design for this?

@sasicodes
Copy link
Contributor Author

@0xchetan Like we have in explore section, same design can be applied here. In timeline v2, we only showing 2 level threads.

POST
|
COMMENT

we need to show, (but there is an issue that api not returning the commentOn value)

POST
|
COMMENT ON
|
COMMENT

@bigint bigint removed the 💸 bounty label Mar 5, 2023
@bigint
Copy link
Member

bigint commented Mar 5, 2023

/bounty $250

@bigint bigint removed $250 labels Mar 5, 2023
@heyxyz heyxyz deleted a comment from algora-pbc bot Mar 11, 2023
@bigint
Copy link
Member

bigint commented Mar 18, 2023

Dupe of #810

@bigint bigint closed this as completed Mar 18, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 7, 2024

This issue has been locked since it has been closed for more than 10 days.

If you found a concrete bug or regression related to it, please open a new bug report.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sasicodes sasicodes

Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@0xchetan @sasicodes @bigint