You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Although there is a clear JSDoc explaining what this validator does, the name of the validator itself is misleading. I expect that it would check that a value is NaN, but it actually checks if a value is of type number. This means that all valid numbers (excluding NaN) will pass this check. I thing that this validator should be named num.isNumberType and there should be another validator which checks if the value is really NaN and it could be named num.isNaN. Will submit a PR.
The text was updated successfully, but these errors were encountered:
Although there is a clear JSDoc explaining what this validator does, the name of the validator itself is misleading. I expect that it would check that a value is
NaN
, but it actually checks if a value is of typenumber
. This means that all valid numbers (excludingNaN
) will pass this check. I thing that this validator should be namednum.isNumberType
and there should be another validator which checks if the value is reallyNaN
and it could be namednum.isNaN
. Will submit a PR.The text was updated successfully, but these errors were encountered: