Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xitca-postgres & diesel-async #621

Closed
godofdream opened this issue Apr 19, 2023 · 5 comments
Closed

xitca-postgres & diesel-async #621

godofdream opened this issue Apr 19, 2023 · 5 comments

Comments

@godofdream
Copy link

I like the postgres implementation.
Would It make sense to re-use the diesel query-builder like diesel-async does?

@fakeshadow
Copy link
Collaborator

fakeshadow commented Apr 19, 2023

Thanks for making an issue. Indeed it would be better to have a high level ORM on top of xitca-postgres.
It should be possible to plug in diesel-async(or something like it) api to xitca-postgres as latter is more or less a tokio-posgres fork with almost identical api.
That said the driver is still a work in progress and lacking some important features like transactions/portal/cancel query etc. So right now an ORM implementation could be left with some major blank impls with no actual functionality. I personally would expect no progress on ORM until the driver is at least feature comparable to tokio-postgres(which is actively being worked on)

@godofdream
Copy link
Author

Ok, I'm looking forward to the feature compatible xitca-postgres.
As long as the api is mostly identical diesel-async could get a feature switch to use xitca-postgres.
Do you want to keep this Issue as reminder?

@godofdream godofdream changed the title xitca-postgres xitca-postgres & diesel-async Apr 19, 2023
@fakeshadow
Copy link
Collaborator

Do you want to keep this Issue as reminder?

Yes let's keep it open.

@fakeshadow
Copy link
Collaborator

fakeshadow commented Sep 15, 2024

xitca-postgres has almost achieve feature parity with tokio-postgres lately and I have started looking into integration with diesel-async.

Initial work can be found here where tokio-postgres is replaced with xitca-postgres as underlying pg client. When this fork is properly tested and optimized I'll look into making it a standalone crate as an extension of diesel-async

Future development will happen in xitca-postgres-diesel. If you have further issue with this topic consider opening another one there

@fakeshadow
Copy link
Collaborator

fakeshadow commented Sep 21, 2024

Close in favor of repo mentioned in last comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants