-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.cluster file need to be modified to relate the message with the cluster number #20
Comments
Hi @who3411, thanks for your interest and PR. |
@hgascon Thank you for your reply.
Yes. All messages are assigned to a cluster in PRISMA. But, some messages are not assigned to a cluster in
|
Sorry, There is supplement in the comment that I sent earlier.
|
It seems that your data has many duplicates, which for efficient reasons |
Thank you for the valuable information. |
Yes, please do. |
I resend new PR #22 used |
I am trying to understand the implementation of PRISMA and PULSAR for my research.
pulsar.core.data.DataHandler
implementation aboutclusterAssignments
supposes that .cluster file will relate all messages(line) belong to cluster number but as a matter of fact they are not yet related. As a result, itunes-xbmc does not seem to create model very well.For instance, the data format of .cluster file which is expected by
pulsar.core.data.DataHandler
is :But currently, the .cluster file data format is:
As a test, I tried to show contents of
pulsar/core/cluster_generator.R
’s variable,clusters
(contents ofclusters
is written to .cluster file). The result is as follow:Under the influence of now .cluster file data format, many messages don’t relate to cluster number. To fix this issue, unique messages cluster number needs to be mapped to all messages cluster number. Unique messages can be made from
prisma.R
’s functionduplicateRemover
’s variableuniqueClasses
. And,pulsar/core/cluster_generator.R
’s variablenames(data$remapper)
relatesuniqueClasses
(data$remapper
relates all messages).My proposed correction procedure is as follow (Please take a look at PR sent later for more information → #21 ):
names(data$remapper)
anduniqueClasses
to map unique messages to all messages(It's calledlines
).lineClusters
).lineClusters
to .cluster file.Thanks for taking your time reading this.
I am not a native speaker so some of my expression might not be accurate. Sorry for this inconvenience.
The text was updated successfully, but these errors were encountered: