Fix missing reference (tabId) in windowsSetCwd() #44
Conversation
The body of windowsSetCwd has been copied from index.js. However the signature has changed, and tabId is no longer passed as an argument. Since the caller already sets curTabId as action.uid, I propose a fix to replace missing tabId with action.uid, although it also makes sense to remove the `tabId === curTabId` condition altogether, because now it will always be true.
|
thanks! |
|
@bagdemir Is any posibility to merge this commit to fix this bug? |
|
@hharnisc or @bagdemir -> Can you merge this PR? Would be greatly appreciated! |
|
Hey everyone 👋 So sorry for the delay here, I've been away on vacation 🌴 Going to merge this fix and publish a new release now. It's become clear this project needs another maintainer, specifically one that lives on windows. Would anyone be up for that? I rely on this for Linux (OS X is same code path for now), so I can promise that will work. |
|
Published as version |
|
Thank you for the fix @asyncore 🙌 |
|
Wow this was fast. Thanks @hharnisc! Works well for me now. |
|
@hharnisc I use Windows primarily and use hyper everyday. I can do maintenance and pull request checking to make sure it works under Windows. |
Hi,
Not sure if this is the best fix but this change does the job.
The body of windowsSetCwd has been copied from index.js. However the signature has changed, and tabId is no longer passed as an argument. Since the caller already sets curTabId as action.uid, I propose a fix to replace missing tabId with action.uid, although it also makes sense to remove the
tabId === curTabIdcondition altogether, because now it will always be true.