Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.2.2 now breaks hyper: "...\hypercwd\setCwd.js:25 Uncaught ReferenceError: tabId is not defined" #43

Closed
campbellgoe opened this issue Apr 22, 2018 · 9 comments

Comments

@campbellgoe
Copy link

campbellgoe commented Apr 22, 2018

Hypercwd 1.2.2 completely breaks hyper. The dev console outputs this:

Plugin hypercwd (1.2.2) loaded.
index.html:35 total init time 2380.575
C:\Users<username>.hyper_plugins\node_modules\hypercwd\setCwd.js:25 Uncaught ReferenceError: tabId is not defined
at windowsSetCwd (C:\Users<username>.hyper_plugins\node_modules\hypercwd\setCwd.js:25)
at C:\Users\u.hyper_plugins\node_modules\hypercwd\windowsActionHandler.js:27
at bundle.js:1
at bundle.js:1
at bundle.js:1
at dispatch (bundle.js:1)
at Object.effect (bundle.js:1)
at bundle.js:1
at bundle.js:1
at bundle.js:1

Hyper works with 1.2.1 and below.

@campbellgoe campbellgoe changed the title This plugin now breaks hyper: "...\hypercwd\setCwd.js:25 Uncaught ReferenceError: tabId is not defined" 1.2.2 now breaks hyper: "...\hypercwd\setCwd.js:25 Uncaught ReferenceError: tabId is not defined" Apr 22, 2018
@n1340t
Copy link

n1340t commented Apr 23, 2018

Same issue, I have to uninstall hyercwd for temporarily use.

@hharnisc
Copy link
Owner

Could you list your hyper version and any other pluggins you're using @gcdeveloper and @cyborg103

@n1340t
Copy link

n1340t commented Apr 23, 2018

I just uninstall hypercwd so I don't really know hypercwd's version but I am pretty sure it is the latest version because I have tried updating plugin but Hyper still doesn't work. My hyper version is 2.0. I also use "hypersearch" and "hyperpower"

@campbellgoe
Copy link
Author

campbellgoe commented Apr 23, 2018

The only plugin I am using is hypercwd. Hyper works when i set it to #1.2.1 or uninstall the plugin completely, but the latest update yesterday (1.2.2) seems to cause this issue because I have been using hypercwd for a few months now just fine.

@Stanzilla
Copy link

Are you guys trying to get this to work on WSL? It's just a guess but if you are, it won't work anyway, see #16.

Please state more info about your environment and use case when you report an issue :)

@campbellgoe
Copy link
Author

I am on Windows 10 and here is my hypercwd config:

//hypercwd config
hypercwd: {
    initialWorkingDirectory: "C:/path/to/my/project"
}

I have also used "C:\\path\\to\\my\\project"

@n1340t
Copy link

n1340t commented Apr 23, 2018

My is window 10 Home. My shell is default window command prompt. Even I close hyper and reopen again, the app fail to start with latest hypercwd version. Hope these info help

@asyncore
Copy link
Contributor

asyncore commented Apr 25, 2018

Hello! I created a PR to fix this: #44

@hharnisc
Copy link
Owner

hharnisc commented May 3, 2018

@asyncore's fix has been publish as version 1.2.3 thanks so much 🙌

@hharnisc hharnisc closed this as completed May 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants