-
Notifications
You must be signed in to change notification settings - Fork 505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reopening #1025: Remove schema calls with no overrides #1065
Conversation
Nope, this will not change with |
Did you manage to figure out what was going with this? |
Not yet, hadn't come back to it yet but i'll look into it soon |
Bringing the branch up to date resolved whatever the issue was. There are a few bugs to get here, i'll open an issue to track but no reason to hold this up while its still caught up. Few other changes in the most recent commit:
|
Removed most occurrences of direct schema calls, exceptions below, and made small improvements to two scrapers .
Improvements
Issues
Some fields return an error when removed. Originally I thought this was related to the MANDATORY_TESTS vs OPTIONAL_TESTS but wasn't able to get to the root. Could use some input if anyone has any ideas but this PR should pass all the tests as is. EDIT: Seems directly related to the issue raised in #1020
With the current code setup the .py file must remain in place for the scraper to be recognized without wild_mode present. This may change in the v15 branch?