Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reopening #1025: Remove schema calls with no overrides #1065

Merged
merged 12 commits into from
May 2, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 0 additions & 33 deletions recipe_scrapers/aberlehome.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,36 +7,3 @@ class AberleHome(AbstractScraper):
@classmethod
def host(cls):
return "aberlehome.com"

def author(self):
return self.schema.author()

def title(self):
return self.schema.title()

def category(self):
return self.schema.category()

def total_time(self):
return self.schema.total_time()

def yields(self):
return self.schema.yields()

def image(self):
return self.schema.image()

def ingredients(self):
return self.schema.ingredients()

def instructions(self):
return self.schema.instructions()

def ratings(self):
return self.schema.ratings()

def cuisine(self):
return self.schema.cuisine()

def description(self):
return self.schema.description()
15 changes: 0 additions & 15 deletions recipe_scrapers/abril.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,21 +8,6 @@ class Abril(AbstractScraper):
def host(cls):
return "claudia.abril.com.br"

def title(self):
return self.schema.title()

def total_time(self):
return self.schema.total_time()

def yields(self):
return self.schema.yields()

def image(self):
return self.schema.image()

def ingredients(self):
return self.schema.ingredients()

def instructions(self):
modo_de_preparo = self.soup.find("div", class_="modo-de-preparo")
instructions = modo_de_preparo.find_all("p")
Expand Down
27 changes: 0 additions & 27 deletions recipe_scrapers/abuelascounter.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,37 +9,10 @@ class AbuelasCounter(AbstractScraper):
def host(cls):
return "abuelascounter.com"

def author(self):
return self.schema.author()

def title(self):
return self.schema.title()

def category(self):
return self.schema.category()

def total_time(self):
return self.schema.total_time()

def yields(self):
return self.schema.yields()

def image(self):
return self.schema.image()

def ingredients(self):
return self.schema.ingredients()

def ingredient_groups(self):
return group_ingredients(
self.ingredients(),
self.soup,
".ingredient-item-group-title",
".wpzoom-rcb-ingredient-name",
)

def instructions(self):
return self.schema.instructions()

def cuisine(self):
return self.schema.cuisine()
18 changes: 0 additions & 18 deletions recipe_scrapers/acouplecooks.py
Original file line number Diff line number Diff line change
Expand Up @@ -6,21 +6,3 @@ class ACoupleCooks(AbstractScraper):
@classmethod
def host(cls):
return "acouplecooks.com"

def title(self):
return self.schema.title()

def total_time(self):
return self.schema.total_time()

def yields(self):
return self.schema.yields()

def image(self):
return self.schema.image()

def instructions(self):
return self.schema.instructions()

def ingredients(self):
return self.schema.ingredients()
33 changes: 0 additions & 33 deletions recipe_scrapers/addapinch.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,27 +9,6 @@ class AddAPinch(AbstractScraper):
def host(cls):
return "addapinch.com"

def author(self):
return self.schema.author()

def title(self):
return self.schema.title()

def category(self):
return self.schema.category()

def total_time(self):
return self.schema.total_time()

def yields(self):
return self.schema.yields()

def image(self):
return self.schema.image()

def ingredients(self):
return self.schema.ingredients()

def ingredient_groups(self):
return group_ingredients(
self.ingredients(),
Expand All @@ -38,18 +17,6 @@ def ingredient_groups(self):
".wprm-recipe-ingredient-group li",
)

def instructions(self):
return self.schema.instructions()

def ratings(self):
return self.schema.ratings()

def cuisine(self):
return self.schema.cuisine()

def description(self):
return self.schema.description()

def equipment(self):
return list(
dict.fromkeys(
Expand Down
6 changes: 0 additions & 6 deletions recipe_scrapers/afghankitchenrecipes.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,6 @@ def author(self):
given_name = self.soup.find("h5", {"class": "given-name"})
return given_name and given_name.find("a", {"rel": "author"}).get_text()

def title(self):
return self.schema.title()

def total_time(self):
ready_in = self.soup.find("li", {"class": "ready-in"})
if not ready_in:
Expand All @@ -31,9 +28,6 @@ def yields(self):
return
return get_yields(servings)

def image(self):
return self.schema.image()

def ingredients(self):
ingredient_elements = self.soup.findAll("li", {"class": "ingredient"})
return [
Expand Down
33 changes: 0 additions & 33 deletions recipe_scrapers/akispetretzikis.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,38 +15,5 @@ def __init__(self, *args, **kwargs):
def host(cls):
return "akispetretzikis.com"

def author(self):
return self.schema.author()

def title(self):
return self.schema.title()

def category(self):
return self.schema.category()

def total_time(self):
return self.schema.total_time()

def yields(self):
return self.schema.yields()

def image(self):
return self.schema.image()

def ingredients(self):
return self.schema.ingredients()

def instructions(self):
return self.schema.instructions()

def ratings(self):
return self.schema.ratings()

def cuisine(self):
return self.schema.cuisine()

def description(self):
return self.schema.description()

def language(self):
return self.recipe_json["locale"]
27 changes: 0 additions & 27 deletions recipe_scrapers/albertheijn.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,24 +10,6 @@ class AlbertHeijn(AbstractScraper):
def host(cls):
return "ah.nl"

def author(self):
return self.schema.author()

def title(self):
return self.schema.title()

def category(self):
return self.schema.category()

def total_time(self):
return self.schema.total_time()

def yields(self):
return self.schema.yields()

def ingredients(self):
return self.schema.ingredients()

def instructions(self):
instructions = [
normalize_string(step.get_text())
Expand All @@ -45,12 +27,3 @@ def instructions(self):

# try schema.org
return self.schema.instructions()

def ratings(self):
return self.schema.ratings()

def cuisine(self):
return self.schema.cuisine()

def description(self):
return self.schema.description()
18 changes: 0 additions & 18 deletions recipe_scrapers/alittlebityummy.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,21 +16,6 @@ def author(self):
if author_tag:
return author_tag.text.replace("Author:", "").strip()

def title(self):
return self.schema.title()

def category(self):
return self.schema.category()

def total_time(self):
return self.schema.total_time()

def yields(self):
return self.schema.yields()

def image(self):
return self.schema.image()

def ingredients(self):
ingredient_blocks = self.soup.select(".ingredients-tab-content div")
seen = set()
Expand Down Expand Up @@ -64,6 +49,3 @@ def instructions(self):
for step in instruction_steps
if step.get_text()
)

def description(self):
return self.schema.description()
36 changes: 0 additions & 36 deletions recipe_scrapers/allrecipes.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,30 +19,6 @@ class AllRecipesCurated(AbstractScraper):
def host(cls):
return "allrecipes.com"

def author(self):
return self.schema.author()

def title(self):
return self.schema.title()

def description(self):
return self.schema.description()

def cook_time(self):
return self.schema.cook_time()

def prep_time(self):
return self.schema.prep_time()

def total_time(self):
return self.schema.total_time()

def yields(self):
return self.schema.yields()

def image(self):
return self.schema.image()

def ingredients(self):
def get_ingredient_text(item, key):
span = item.find("span", {"data-ingredient-" + key: True})
Expand All @@ -56,18 +32,6 @@ def get_ingredient_text(item, key):

return ingredients_list

def instructions(self):
return self.schema.instructions()

def ratings(self):
return self.schema.ratings()

def cuisine(self):
return self.schema.cuisine()

def category(self):
return self.schema.category()


class AllRecipesUser(AbstractScraper):
"""Parse "unpublished" personal recipes on AllRecipes.com.
Expand Down
24 changes: 0 additions & 24 deletions recipe_scrapers/alltomat.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,34 +8,10 @@ class AllTomat(AbstractScraper):
def host(cls):
return "alltommat.se"

def author(self):
return self.schema.author()

def title(self):
return self.schema.title()

def total_time(self):
return self.schema.total_time()

def yields(self):
return self.schema.yields()

def image(self):
return self.schema.image()

def ingredients(self):
return self.schema.ingredients()

def ingredient_groups(self):
return group_ingredients(
self.ingredients(),
self.soup,
".ingredients-section h2",
".ingredients-list li",
)

def instructions(self):
return self.schema.instructions()

def ratings(self):
return self.schema.ratings()
Loading
Loading