Update tine.no scraper #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To conform with scraper generation from templates
jayaddison
reviewed
Jan 24, 2022
jayaddison
reviewed
Jan 24, 2022
|
This looks great, thank you @mathiazom - and thanks too for being meticulous about the details in the description and commit messages. I've left two optional comments and will take another look after you've had time to respond to those. |
Also regenerated the scraper from templates to add some missing methods
mathiazom
force-pushed
the
update-tineno-scraper
branch
from
15b20a4
to
4862713
Compare
|
Thanks for the comments @jayaddison, I have now updated the branch with the suggested changes. |
jayaddison
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #484
The scraper implementation for Tine.no has been updated to resolve issues with missing data in the scrape result.
Since tine.no provides recipe data as JSON-LD, I have replaced most of the existing scraper with the general Schema.org scraper. The exceptions are for the recipe image (to retrieve higher resolution) and a cosmetic detail for the instructions.
Also had to work around an apparent incorrect property naming in the data from tine.no. I chose to use a dictionary key replacement solution from SO (user 'baldr'), and have attempted to properly credit the original creator.
Finally, expanded scraper templates, abstract scraper and scraper factory, but not completely sure how to best organize things. Suggestions are very welcome 😃