Skip to content
This repository has been archived by the owner on Apr 1, 2024. It is now read-only.

CPPFLAGS not passed to xhp/Makefile #53

Closed
simonwelsh opened this issue Mar 2, 2014 · 3 comments
Closed

CPPFLAGS not passed to xhp/Makefile #53

simonwelsh opened this issue Mar 2, 2014 · 3 comments
Labels
php5-extension

Comments

@simonwelsh
Copy link
Contributor

Passing CPPFLAGS to ./configure correctly sets them in Makefile, though not in xhp/Makefile, so compiling with custom C++ include paths requires manually editing that file.
@Swahvay
Copy link
Contributor

Swahvay commented Apr 11, 2014

Should the custom CPPFLAGS replace what is in xhp/Makefile or append to it?

@simonwelsh
Copy link
Contributor Author

Usual practice is to do an append.

@fredemmott
Copy link
Contributor

This issue appears to be specific to the PHP5 extension, which is no longer part of this repository. The extension is available at https://github.com/facebookarchive/xhp-php5-extension, but is not supported.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
php5-extension
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@simonwelsh @fredemmott @Swahvay