Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: avoid e2e code to depend on application code #545

Open
hi-ogawa opened this issue Dec 27, 2023 · 1 comment
Open

refactor: avoid e2e code to depend on application code #545

hi-ogawa opened this issue Dec 27, 2023 · 1 comment

Comments

@hi-ogawa
Copy link
Owner

hi-ogawa commented Dec 27, 2023

// TODO: avoid e2e code to depend on application code

The reason is that, since playwright runs its own typescript transpilation, it would block using certain vite specific features in application code (though this already happens with "tsx" used for local cli...).

@hi-ogawa
Copy link
Owner Author

hi-ogawa commented Dec 27, 2023

Probably, what we have to do is to ensure Vite/Remix specific features are only used within app/routes files. Other "utilities" should be able to run at least on Vitest and Tsx anyways.

But, I still feels it's wrong for playwright test code to use much of internal details utilities to check e2e features...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant