Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for HHH-10510 #1287

Closed
wants to merge 2 commits into from
Closed

Conversation

andrei-ivanov
Copy link
Contributor

No description provided.

@vladmihalcea
Copy link
Contributor

Is this really a fix for HHH-10511? The JIRA description is about a many-to-many/one-to-many attribute type resolving.

@andrei-ivanov andrei-ivanov changed the title Fix for HHH-10511 Fix for HHH-10510 Mar 7, 2016
@andrei-ivanov
Copy link
Contributor Author

Grr, it's for HHH-10510, sorry about that

@vladmihalcea
Copy link
Contributor

Makes sense now: https://hibernate.atlassian.net/browse/HHH-10510

Two things before I merge it:

  1. Did you sign the CLA?
  2. Is there any unit test for this?

@andrei-ivanov
Copy link
Contributor Author

I don't think I've signed it. Can you point me to the instructions please?
Regarding the unit test, like I've mentioned in the issue, I can't manage to make Hibernate replicate the problem without a mock :-(

@vladmihalcea
Copy link
Contributor

The CLA page is here. Regarding a test, I'll write on the JIRA issue instead.

@andrei-ivanov
Copy link
Contributor Author

CLA signed

@vladmihalcea
Copy link
Contributor

Great. I wrote a step-by-step guide for writing the Unit Test. Let me know if there's anything I can help you with.

@vladmihalcea
Copy link
Contributor

I created a new PR containing both your change and a test case for this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants