Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HHH-13221 - When lazy fetching child entities outside the session DB commit is fired in a read-only transaction. #2753

Closed
wants to merge 2 commits into from

Conversation

vladmihalcea
Copy link
Contributor

@gsmet
Copy link
Member

gsmet commented Jan 24, 2019

This one requires a proper review by Gail, please don't merge it yet.

@vladmihalcea
Copy link
Contributor Author

vladmihalcea commented Jan 24, 2019

It's not a critical issue. I tried various scenarios and it was always just one select being triggered, even for join formula, custom loaders or using caching.

We can post pone it as long as it's necessary.

@gbadner
Copy link
Contributor

gbadner commented Mar 11, 2019

I just pushed a change to the test to use FetchMode.SELECT to load an association. This forces the association to loaded in a different statement.

I don't think this is a good idea.

@vladmihalcea
Copy link
Contributor Author

@gbadner Thanks for the commit. I think we should close this PR and reject the issue.

@gbadner gbadner closed this Mar 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants