Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change package API to hide redis client library used internally #45

Closed
hibiken opened this issue Jan 7, 2020 · 0 comments · Fixed by #54
Closed

Change package API to hide redis client library used internally #45

hibiken opened this issue Jan 7, 2020 · 0 comments · Fixed by #54
Assignees
Labels
enhancement New feature or request

Comments

@hibiken
Copy link
Owner

hibiken commented Jan 7, 2020

Is your feature request related to a problem? Please describe.
Currently, both Client and Background constructor takes go-redis/redis/v7 as a parameter. This will become an issue when there is a new version or if we want to switch to another redis-client library. The change will require major version update, which we don't want to do just for a redis-client library change.

Describe the solution you'd like
We should abstract this away from asynq package users and take RedisClientOption as a parameter.

Describe alternatives you've considered
None so far.

@hibiken hibiken added the enhancement New feature or request label Jan 7, 2020
@hibiken hibiken self-assigned this Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant