[BUG] kill -TERM pid the process still exists

[cielu]

mac os .

I don't know if this is a bug .

The process could only kill by kill -9

[hibiken]

@cielu Did you manage to resolve the issue?
You probably need to build the binary first instead of using go run .

[cielu]

@hibiken Thank you ! I have resolve the issue .

I know the reason about can't kill that process .

Asynq have own graceful shut down way , but the Gin framework don't

asynq :

	// Wait for a signal to terminate.
	sigs := make(chan os.Signal, 1)
	signal.Notify(sigs, syscall.SIGTERM, syscall.SIGINT, syscall.SIGTSTP)
	for {
		sig := <-sigs
		if sig == syscall.SIGTSTP {
			bg.processor.stop()
			bg.pinfo.SetState("stopped")
			continue
		}
		break
	}

so , if I want them work together , Gin should graceful shut down too (receive the signal to exit).

	// Init router
	router := routes.InitRouter()
	
	srv := &http.Server{
		Addr:    ":" + setting.AppCfg.AppPort,
		Handler: router,
	}
	/
	go func() {
		// service connections
		if err := srv.ListenAndServe(); err != nil && err != http.ErrServerClosed {
			log.Fatalf("listen: %s\n", err)
		}
	}()
	// Wait for interrupt signal to gracefully shutdown the server
	quit := make(chan os.Signal)
	// kill (no param) default send syscanll.SIGTERM
	// kill -2 is syscall.SIGINT
	// kill -9 is syscall. SIGKILL but can"t be catch, so don't need add it
	signal.Notify(quit, os.Interrupt)
	<-quit
	log.Println("Shutdown Server ...")
	// 
	ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second)
	defer cancel()
	// 
	if err := srv.Shutdown(ctx); err != nil {
		log.Fatal("Server Shutdown:", err)
	}
	log.Println("Server exiting")

But it is still recommend to separate the asynq workers

[hibiken]

Glad that you were able to resolve the issue.
Yes, intended use case for Asynq is to have its own worker binary separate from web server binary.

This was a useful feedback, maybe I can export Start and Stop methods for the Background to let the user of the library manually handle shutdown. I'll consider that if more users request it.

Thanks for creating the issues!

[cielu]

Haha，Look forward to version 1.0