Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] stop usage of the internal folder #859

Open
elee1766 opened this issue Apr 10, 2024 · 0 comments
Open

[FEATURE REQUEST] stop usage of the internal folder #859

elee1766 opened this issue Apr 10, 2024 · 0 comments
Assignees
Labels
idea Feature Suggestion or Idea

Comments

@elee1766
Copy link

elee1766 commented Apr 10, 2024

hi

we are using asynq for a while in some production services and love it!

reading through some prs here - see that you would prefer to keep development in this repository, and we totally agree that its the best option.

however - we are looking to build extensions/interfaces which require us to be able to access the protos in /internal. for instance, and alternative client, which is something we think shouldnt live in the package itself, but better published as a third party module which depends asynq.

this would also allow faster iteration on top of asynq which does not explicitly require your attention and

so i think it would be good to rename /internal -> /pkg

the alternative is that we will just continue to use a forked asynq and replace in all our projects in order to use our extensions.

if you agree, happy to make the pr.

@elee1766 elee1766 added the enhancement New feature or request label Apr 10, 2024
@kamikazechaser kamikazechaser added idea Feature Suggestion or Idea and removed enhancement New feature or request labels Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
idea Feature Suggestion or Idea
Projects
None yet
Development

No branches or pull requests

3 participants