Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] armors bugging when playing emote / getting kicked due to "Cannot interact with self!" #76

Closed
3 tasks done
ghost opened this issue Mar 11, 2023 · 3 comments
Closed
3 tasks done
Labels
bug Something isn't working

Comments

@ghost
Copy link

ghost commented Mar 11, 2023

I have checked...

  • I am using the latest version of HMCCosmetics
  • I am using the latest version of any dependencies
  • I have checked if any similar bug reports exist

Description

https://www.youtube.com/watch?v=HLp1usiabvQ

Steps to reproduce

i get kicked if i click on air(or armorstands idk) (doesnt matter left or right click) while playing an emote

Plugin Version

2.2.4(self build)

ModelEngine Version

No response

Server Version

git-Paper-307 (MC: 1.19.2)

How breaking is the bug?

Minor Bug - Plugin completely functional, but features have non-working aspects

@ghost ghost added the bug Something isn't working label Mar 11, 2023
@LoJoSho
Copy link
Member

LoJoSho commented Mar 11, 2023

This is a known issue and has been discussed on Discord on solutions. I can not personally replicate it, but many other people have had this issue. It happens because we sent a client packet that sends the player to a different location than where the server thinks they are and so when they interact while emoting, it can kicks them.

This should fix it, but apparently, it isn't. https://github.com/HibiscusMC/HMCCosmetics/blob/remapped/common/src/main/java/com/hibiscusmc/hmccosmetics/listener/PlayerGameListener.java#L388-L407

@ghost
Copy link
Author

ghost commented Mar 11, 2023

cancelling PacketType.Play.Client.USE_ENTITY instead of PacketType.Play.Client.ARM_ANIMATION fixes the problem

@LoJoSho
Copy link
Member

LoJoSho commented Mar 12, 2023

Tested and appears to work, 9f6c7db

Ty for your information on the matter, I never would have guessed it was that packet!

@LoJoSho LoJoSho closed this as completed Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant