Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't create an album #3

Closed
OkanEsen opened this issue Apr 27, 2013 · 6 comments
Closed

Doesn't create an album #3

OkanEsen opened this issue Apr 27, 2013 · 6 comments

Comments

@OkanEsen
Copy link

If you give reddit user as a source, it downloads all pictures but doesn't create a new album. It just downloads all pictures and put them in one folder.

@hickford
Copy link
Owner

Yo do you have an example for me to test?

The script orders the files by the last modified date, which I thought was pretty neat

    timestamp = new Date(result.headers['last-modified'])
    url = "http://i.imgur.com/#{hash}.jpg"
    destination = path.join("#{user}","#{user}-#{timestamp.toISOString().replace(/:/g,'.')}-#{hash}.#{extension}")

@OkanEsen
Copy link
Author

Just try to fetch several albums of one reddit user. You will see, that it will just download all images in one folder, instead of creating one folder for each imgur album. That's probably intended but it would be pretty nice if you could make that small change, so it does create one folder for each imgur album.

@hickford
Copy link
Owner

That should be doable, I'll try next week. What should the script do if an image is in more than one album?

@OkanEsen
Copy link
Author

Just an idea: let the user decide, whether he wants to download them several times by using a parameter (e.g. imgurgitate http://reddit.com/user/blubb.json --skipmultipleimages).

Thanks in advance!

@OkanEsen
Copy link
Author

Did you come up with something? :-)

@hickford
Copy link
Owner

Eventually. Added an a new option --albums 8a3f778

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants