Added time tracking clamping setting #149
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
July 30, 2021 10:06
arBmind
reviewed
Aug 2, 2021
| @@ -42,6 +46,21 @@ def round_interval(time_interval, project: nil) | |||
| end | |||
| end | |||
|
|
|||
| def clamp?(start, project: nil) | |||
| clamp_limit = clamp_limit project: project | |||
| stop = Time.now.change(sec: 0) + 1.minute | |||
There was a problem hiding this comment.
This looks like we need actual rounding here?
The +1.minute seems wrong when seconds were 0 before: "0min 0sec" => "1min 0sec".
In lib/ Hourglass::DateTimeCalculation is the "rounding" logic used for booking.
There was a problem hiding this comment.
Why are we doing rounding for sub minutes here? is it actually necessary?
There was a problem hiding this comment.
It is the behavior how time logs are updated currently. This is the reason why clamp should also use the "rounded" stop time.
Additionally we always add 1 minute to prevent a time tracked which is less then one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.