Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate SBOL 2.2 #68

Merged
merged 39 commits into from
Jan 18, 2019
Merged

Generate SBOL 2.2 #68

merged 39 commits into from
Jan 18, 2019

Conversation

dany-fu
Copy link
Collaborator

@dany-fu dany-fu commented Nov 3, 2018

It would be good if you could enter some random specifications to try to break the SBOL generation. You don't have to worry about the correctness of it, just see if you can break any of the assumptions I'm making (there are lots). The SBOL/errors will get printed to the console.

If you want to take it a step further, you can copy the SBOL into this validator which checks for the correctness of the structure.

This branch also fixes the missing icon bug that we noticed during the Broad demo.

The bulk of the "files changed" are from when Glenn added a bunch of new svg files for new icons. Most of my SBOL changes are in sbol.js and constellation.js

@dany-fu dany-fu requested a review from lucyq November 3, 2018 18:05
@lucyq
Copy link
Member

lucyq commented Nov 8, 2018

@dany-fu tests are not passing :S

@dany-fu
Copy link
Collaborator Author

dany-fu commented Nov 8, 2018

All the test are failing with a is not a valid SBOL part which is a check we put in a while back to that validates the name of the input parts against a list in sbol.js. Its benefit is that it standardizes the inputs and we can readily assign the correct role in SBOL, but at the same time, it might be too restrictive and relies too heavily on how often that list in sbol.js is updated. Let's confer with Nic tomorrow.

@dany-fu
Copy link
Collaborator Author

dany-fu commented Nov 9, 2018

@lucyq passing now

Glenn did fix the unit tests a while back when he implemented the check, but with all the merging it got lost. Regardless, Nic said he doesn't police the part names in Knox, so we should just mirror that.

@coveralls
Copy link

coveralls commented Nov 9, 2018

Coverage Status

Coverage increased (+6.3%) to 93.827% when pulling 18cb122 on generate_sbol into 82e6b21 on master.

@dany-fu dany-fu force-pushed the generate_sbol branch 5 times, most recently from 68d3295 to 111f8a7 Compare November 24, 2018 00:30
@lucyq lucyq merged commit b240ce3 into master Jan 18, 2019
@lucyq lucyq deleted the generate_sbol branch January 18, 2019 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants