-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate SBOL 2.2 #68
Conversation
Limit categories to valid terms found in sboljs and updated svg files
765ec15
to
497d2b3
Compare
@dany-fu tests are not passing :S |
All the test are failing with |
@lucyq passing now Glenn did fix the unit tests a while back when he implemented the check, but with all the merging it got lost. Regardless, Nic said he doesn't police the part names in Knox, so we should just mirror that. |
68d3295
to
111f8a7
Compare
111f8a7
to
5188c7c
Compare
234be82
to
3d7e1ac
Compare
3d7e1ac
to
fc306c3
Compare
047d790
to
18cb122
Compare
It would be good if you could enter some random specifications to try to break the SBOL generation. You don't have to worry about the correctness of it, just see if you can break any of the assumptions I'm making (there are lots). The SBOL/errors will get printed to the console.
If you want to take it a step further, you can copy the SBOL into this validator which checks for the correctness of the structure.
This branch also fixes the missing icon bug that we noticed during the Broad demo.
The bulk of the "files changed" are from when Glenn added a bunch of new svg files for new icons. Most of my SBOL changes are in sbol.js and constellation.js