-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC][Discussion] Automatic Parallelization #335
Comments
Hi @soodoshll, thanks for the draft! It looks good as a first verion rfc draft! I have several suggestions:
|
The design looks good to me. Hi @soodoshll and @xinli-git, could you also discuss how to seperate the whole feature into relative small steps to implement? We can use this issue to track the PRs related to this RFC, something like apache/tvm#15319. Thanks! |
Hi @yaoyaoding, thanks for your suggestions. I've fixed the draft. The whole features can be decomposed into the following steps:
I'm working on 1 after it is done, we can start 2 and 3. I have a prototype of 3, which I will integrate later. Hi @xinli-git, let's work in the auto-parallel branch. |
I found that resharding (tensor conversion between ops with different specifications) sometimes requires the collective communication primitive Though nccl does not directly supports I'd suggest treat it as a low-prioritized TODO item and see if it will really cause performance issue. We can fix it after finishing the backbone of the whole pipeline. |
Thanks! @soodoshll. The RFC is very detailed. For modelling computation, it seems that Alpa assumes that all tensor contraction OPs (MM, Conv) must be fully sharded so all such ops that same computation cost under different sharding strategies. They also observe that other OPs have negligible runtime cost for computation. (I verified this as well). As a result, they think there was no need to model computation. Since this feature probably requires a month of work for multiple people (currently me and Qidong) I was thinking maybe we can leverage github Projects (https://github.com/hidet-org/hidet/projects?query=is%3Aopen) @yaoyaoding if you think that's a good idea I will take a lead on this |
Hi @xinli-git, sounds good to me. I have not used the github project feature before, but you can have a try and let's see whether it helps the orgnization and planning. |
rendered rfc
The text was updated successfully, but these errors were encountered: