Set Java 8 as Minimum Required Version and Upgrade Dependencies #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Upgraded Bouncy Castle from 1.70 to 1.75 - Upgraded SLF4J from 1.7.36 to 2.0.7 - Upgraded Logback from 1.2.11 to 1.3.8 - Upgraded Apache MINA SSHD from 2.8.0 to 2.10.0 - Upgraded Grizzly HTTP Server from 2.4.4 to 3.0.1 - Upgraded Testcontainers from 1.16.2 to 1.18.3 - Refactored references and removed HttpClient dependency - Upgraded GitHub Actions setup-java from 1 to 3 - Updated GitHub Actions to use Temurin JDK 11 - Added OpenSSL upgrade to RSA Key Tests
Codecov Report
@@ Coverage Diff @@
## master #874 +/- ##
============================================
+ Coverage 65.29% 65.49% +0.19%
- Complexity 1436 1443 +7
============================================
Files 209 209
Lines 8060 8060
Branches 746 746
============================================
+ Hits 5263 5279 +16
+ Misses 2400 2386 -14
+ Partials 397 395 -2 |
hierynomus
approved these changes
Jun 30, 2023
|
Hello, When can we expect this to be released? Thanks for the changes. |
|
Thanks for the initial review of these changes @hierynomus. Is there anything that needs to be adjusted before this can go forward? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests changes the Java compiler release version from 7 to 8, making the Java 8 the minimum required version for using SSHJ.
Runtime dependency changes include the following updates:
Both of these runtime dependency upgrades require Java 8.
Test dependency changes include the following updates:
GitHub Action changes include the following updates:
Test code changes include replacing the Apache HttpClient library references to Java HttpURLConnection, allowing for the test dependency to be removed.
Spock 2.0 uses the Gradle JUnit Platform runner, supporting simplified build configuration.
The RSA algorithm integration tests could fail due to a mismatch between the OpenSSH and OpenSSL versions, requiring an additional package upgrade command.