Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace custom Base64 with java.util.Base64 #879

Merged
merged 1 commit into from
Jul 14, 2023

Conversation

exceptionfactory
Copy link
Contributor

This pull request replaces the custom net.schmizz.sshj.common.Base64 class with the standard java.util.Base64 implementation.

Following the changes in #874 to make Java 8 the minimum required version, maintaining a standalone Base64 implementation is no longer required.

Although the Base64 class has remained stable, it does not have standalone unit tests. Switching to java.util.Base64 provides the same functionality and all tests pass using the standard implementation.

@sonatype-lift
Copy link

sonatype-lift bot commented Jul 14, 2023

Sonatype Lift is retiring

Sonatype Lift will be retiring on Sep 12, 2023, with its analysis stopping on Aug 12, 2023. We understand that this news may come as a disappointment, and Sonatype is committed to helping you transition off it seamlessly. If you’d like to retain your data, please export your issues from the web console.
We are extremely grateful and thank you for your support over the years.

📖 Read about the impacts and timeline

@codecov-commenter
Copy link

Codecov Report

Merging #879 (8ff2de2) into master (39a7be9) will increase coverage by 2.72%.
The diff coverage is 93.54%.

@@             Coverage Diff              @@
##             master     #879      +/-   ##
============================================
+ Coverage     65.34%   68.06%   +2.72%     
+ Complexity     1441     1399      -42     
============================================
  Files           209      208       -1     
  Lines          8060     7463     -597     
  Branches        746      637     -109     
============================================
- Hits           5267     5080     -187     
+ Misses         2396     2038     -358     
+ Partials        397      345      -52     
Impacted Files Coverage Δ
...hj/transport/verification/FingerprintVerifier.java 82.75% <85.71%> (+10.03%) ⬆️
...sshj/transport/verification/KnownHostMatchers.java 91.48% <100.00%> (ø)
.../sshj/userauth/keyprovider/OpenSSHKeyFileUtil.java 83.33% <100.00%> (ø)
...sshj/userauth/keyprovider/OpenSSHKeyV1KeyFile.java 84.66% <100.00%> (ø)
...nomus/sshj/userauth/keyprovider/bcrypt/BCrypt.java 96.46% <100.00%> (+13.64%) ⬆️
...sshj/transport/verification/OpenSSHKnownHosts.java 57.14% <100.00%> (-0.22%) ⬇️
...chmizz/sshj/userauth/keyprovider/PuTTYKeyFile.java 80.90% <100.00%> (ø)

... and 3 files with indirect coverage changes

@hierynomus hierynomus merged commit f35c2bd into hierynomus:master Jul 14, 2023
@hierynomus
Copy link
Owner

Thanks for another pull request! Looking good and merged.

snesm added a commit to CDCgov/prime-reportstream that referenced this pull request Sep 7, 2023
oslynn added a commit to CDCgov/prime-reportstream that referenced this pull request Sep 28, 2023
* Bump com.hierynomus:sshj from 0.32.0 to 0.36.0 in /prime-router

Bumps [com.hierynomus:sshj](https://github.com/hierynomus/sshj) from 0.32.0 to 0.36.0.
- [Commits](hierynomus/sshj@v0.32.0...v0.36.0)

---
updated-dependencies:
- dependency-name: com.hierynomus:sshj
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

* update for hierynomus/sshj#879

* Modified SftpTransport to be able to handle SSHRSA as older version

* Modified SftpTransport to be able to handle SSHRSA as older version

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Stephen Nesman <94193373+snesm@users.noreply.github.com>
Co-authored-by: Ott Sathngam <ott.sathngam@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants