Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recommended vscode extensions! 💻 #34

Merged
merged 2 commits into from
Dec 5, 2019

Conversation

kutyel
Copy link
Member

@kutyel kutyel commented Dec 4, 2019

Apparently this is a new feature of vscode, and when you open a project with this settings a prompt appears asking you to auto-install the recommended extensions! 👏 I think this behaviour is quite handy and will help the new contributors to follow https://github.com/higherkindness/mu-haskell/blob/master/DEVELOPMENT.md 😉

@kutyel kutyel requested a review from serras December 4, 2019 11:48
.vscode/settings.json Outdated Show resolved Hide resolved
Copy link
Collaborator

@serras serras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just leave out the settings.json file, and maybe make it more clear in the DEVELOPMENT.md file that we want people to run this before submitting any patch.

@kutyel kutyel requested a review from serras December 5, 2019 08:00
@serras serras merged commit 80f6dcf into master Dec 5, 2019
@serras serras deleted the vscode-recommended-extensions branch December 5, 2019 08:23
kutyel added a commit that referenced this pull request Jan 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants