Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds *frees-rpc-testing* including *grpc-testing* dependency #142

Merged
merged 1 commit into from
Jan 17, 2018

Conversation

juanpedromoreno
Copy link
Member

This PR adds a new sbt module (artifact frees-rpc-testing) to provide transitively the grpc-testing dependency. In this way, library users don't need to know which is the gRPC version underneath.

Copy link
Contributor

@fedefernandez fedefernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov-io
Copy link

Codecov Report

Merging #142 into master will decrease coverage by 4.75%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #142      +/-   ##
==========================================
- Coverage   92.66%   87.91%   -4.76%     
==========================================
  Files          23       23              
  Lines         259      273      +14     
  Branches        7        7              
==========================================
  Hits          240      240              
- Misses         19       33      +14

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8cbc72a...ab9596f. Read the comment docs.

@juanpedromoreno juanpedromoreno merged commit c8cf783 into master Jan 17, 2018
@juanpedromoreno juanpedromoreno deleted the feature/grpc-testing-provided-by-frees-rpc branch January 17, 2018 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants