-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cross-build the tests module #1463
Conversation
We can't cross-build the config module because it depends on pureconfig, so we need to remove this inter-module dependency in order to cross-build the tests module. Moved the relevant tests into the config module. Also fixed one of the tests that didn't make much sense, and added a missing config file.
Anything that uses the `@service` annotation was moved to src/test/scala-2/.
Now the tests module is cross-built, we can move these tests out of the rpc-service module
@@ -62,8 +62,6 @@ class DropwizardMetricsTests extends ScalaCheckSuite { | |||
(registry.getTimers().asScala.toMap, registry.timer(gaugeName).getCount) | |||
case Counter => | |||
(registry.getCounters().asScala.toMap, registry.counter(gaugeName).getCount) | |||
case _ => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Scala 3 compiler helpfully pointed out that this case is unreachable!
@@ -0,0 +1 @@ | |||
rpc.server.port = 51111 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
where is this used @cb372 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@service
macro tosrc/test/scala-2/
The next step will be to gradually rewrite the uses of
@service
in the tests to use sourcegen instead. But that will require some thought, as the tests use many combinations of serialization type (Avro/AvroWithSchema/Protobuf), compression (Gzip/Identity) and idiomatic endpoints (true/false). It's not immediately clear how we can support that, as sbt-mu-srcgen only lets you configure those on a per-project basis.