Cross-build the tests module #1463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can't cross-build the config module because it depends on pureconfig, so we need to remove this inter-module dependency in order to cross-build the tests module. Moved the relevant tests into the config module. Also fixed one of the tests that didn't make much sense, and added a missing config file.
Anything that uses the `@service` annotation was moved to src/test/scala-2/.
Now the tests module is cross-built, we can move these tests out of the rpc-service module
cb372
commented
Apr 22, 2022
| @@ -62,8 +62,6 @@ class DropwizardMetricsTests extends ScalaCheckSuite { | |||
| (registry.getTimers().asScala.toMap, registry.timer(gaugeName).getCount) | |||
| case Counter => | |||
| (registry.getCounters().asScala.toMap, registry.counter(gaugeName).getCount) | |||
| case _ => | |||
There was a problem hiding this comment.
The Scala 3 compiler helpfully pointed out that this case is unreachable!
fedefernandez
approved these changes
Apr 22, 2022
| @@ -0,0 +1 @@ | |||
| rpc.server.port = 51111 | |||
There was a problem hiding this comment.
where is this used @cb372 ?
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@servicemacro tosrc/test/scala-2/The next step will be to gradually rewrite the uses of
@servicein the tests to use sourcegen instead. But that will require some thought, as the tests use many combinations of serialization type (Avro/AvroWithSchema/Protobuf), compression (Gzip/Identity) and idiomatic endpoints (true/false). It's not immediately clear how we can support that, as sbt-mu-srcgen only lets you configure those on a per-project basis.