-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New example: TodoList application #256
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add basic protocol * Add codecs in common module * Add ping pong rpc server * Add ping pong client for IO and Task * Use StdIn * Remove unnecessary for comprehension from client program * Use StdIn in other executor * Remove example-todolist-common module * Simplified todolist example * Update README.md * Fix README.md * Fix README copyright
* Add Tag protocol * Update Tag Protocol * Update frees version to 0.8.1-SNAPSHOT * Add freestyle-todolist-lib dependency in common settings * Place each protocol in different files * Implement TagRpcService in server * Move PingPongClient to its own file * WIP Update protocol and server * WIP Tag client * Change protocol to Avro * Fix client * Add snapshots resolver * Remove println * Use snapshot version only for required dependencies * Run all programas with one effect
* Add TodoList and TodoItem protocols * Avoid using get in options * Rename protocol message Tag to TagMessage * Implement TodoListRPCServiceHandler * Add handler for TodoItemRpcService * Implement TodoListClient * Add client for TodoItem * Implement client program * Fix TodoItem conversions * Remove comment * Improve clients * Minor improvements
f4d9336
to
9c824bc
Compare
juanpedromoreno
approved these changes
Apr 27, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @JesusMtnez @pirita !
eperinan
approved these changes
Apr 30, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.