Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uses fs2-grpc for the fs2 integration #477

Merged
merged 2 commits into from
Nov 16, 2018
Merged

Uses fs2-grpc for the fs2 integration #477

merged 2 commits into from
Nov 16, 2018

Conversation

fedefernandez
Copy link
Contributor

@fedefernandez fedefernandez commented Nov 15, 2018 •
edited
Loading

fs2-grpc doesn't have support for compression at the server level. A PR was submitted for addressing that: https://github.com/fiadliel/fs2-grpc/pull/42.

The fs2 support is still experimental so, IMO we're fine.

@fedefernandez fedefernandez changed the title [WIP] - Uses fs2-grpc for the fs2 integration Uses fs2-grpc for the fs2 integration Nov 15, 2018
L-Lavigne
L-Lavigne approved these changes Nov 15, 2018
View reviewed changes
Copy link
Contributor

@L-Lavigne L-Lavigne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Good to see the disabled tests being restored, hopefully this resolves some of our long-standing test issues in CI. 👍

@fedefernandez
Copy link
Contributor Author

Let's see. I think they aren't solved completely but at least didn't fail in the last 6/8 builds

pepegar
pepegar approved these changes Nov 16, 2018
View reviewed changes
Copy link
Member

@pepegar pepegar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome to see that we won't default to Monix anymore as a streaming framework!

@fedefernandez fedefernandez merged commit d0e7efa into master Nov 16, 2018
@fedefernandez fedefernandez deleted the ff/proof-of-concept-fs2 branch November 16, 2018 14:52
@fedefernandez fedefernandez mentioned this pull request Nov 19, 2018
Closed
@L-Lavigne L-Lavigne mentioned this pull request Mar 6, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepegar pepegar pepegar approved these changes

@L-Lavigne L-Lavigne L-Lavigne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fedefernandez @pepegar @L-Lavigne