Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freestyle 0.4.0 Upgrade #56

Merged
merged 3 commits into from
Oct 17, 2017
Merged

Conversation

juanpedromoreno
Copy link
Member

@juanpedromoreno juanpedromoreno commented Oct 17, 2017

This PR upgrades to Freestyle 0.4.0, it also:

  • Upgrades Monix Adapters based on Monix 3.0.0-M1.
  • Upgrades to cats 1.0.0-MF.
  • Removes freestyle-async-monix .
  • Adds frees-async-guava (custom handlers for ListenableFuture in this project have been removed).
  • Upgrades the macros.
  • Releases frees-rpc 0.0.8 version.
  • Others.

* Upgrades Monix Adapters based on Monix 3.0.0-M1
* Upgrades to cats 1.0.0.-MF
* Changes freestyle-async-monix by frees-async-cats-effects
* Upgrades the macros
* Others
@codecov-io
Copy link

codecov-io commented Oct 17, 2017

Codecov Report

Merging #56 into master will decrease coverage by 2.61%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
- Coverage   20.85%   18.23%   -2.62%     
==========================================
  Files          16       15       -1     
  Lines         163      159       -4     
==========================================
- Hits           34       29       -5     
- Misses        129      130       +1
Impacted Files Coverage Δ
rpc/src/main/scala/internal/MonixAdapters.scala 0% <ø> (ø) ⬆️
rpc/src/main/scala/internal/service/service.scala 0% <ø> (ø) ⬆️
rpc/src/main/scala/client/implicits.scala 0% <ø> (-33.34%) ⬇️
...in/scala/client/handlers/ClientCallsMHandler.scala 0% <0%> (ø) ⬆️
rpc/src/main/scala/internal/client/calls.scala 0% <0%> (ø) ⬆️
rpc/src/main/scala/internal/service/calls.scala 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37e40cc...861cf37. Read the comment docs.

@juanpedromoreno juanpedromoreno changed the title [WIP] Freestyle 0.4.0 Upgrade Freestyle 0.4.0 Upgrade Oct 17, 2017
Copy link
Contributor

@fedefernandez fedefernandez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

```scala
"io.frees" %%% "frees-rpc" % "0.0.7"
```

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed anymore?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not compatible with Scalajs for now, see #21

@juanpedromoreno juanpedromoreno merged commit 5180a8f into master Oct 17, 2017
@juanpedromoreno juanpedromoreno deleted the feature/freestyle-0.4.0-upgrade branch October 17, 2017 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants