Make the streaming implementation configurable #731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a `srcGenStreamingImplementation` sbt setting to the idlgen plugin to control whether generated Scala code contains `fs2.Stream` or `monix.reactive.Observable` in RPC endpoint definitions.
|
(working on updating the docs now) |
avroidl is not supported as a language by highlightjs
Codecov Report
@@ Coverage Diff @@
## master #731 +/- ##
==========================================
+ Coverage 81.42% 81.67% +0.25%
==========================================
Files 73 73
Lines 1168 1168
Branches 16 14 -2
==========================================
+ Hits 951 954 +3
+ Misses 217 214 -3
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
srcGenStreamingImplementationsbt setting to the idlgen plugin to control whether generated Scala code containsfs2.Streamormonix.reactive.Observablein RPC endpoint definitions. Defaults to FS2.Also fixed the Avro code fences on the microsite while I was updating the documentation, as I noticed they were broken by the recent sbt-microsites upgrade.
Checklist