Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async Implicits provided by frees-rpc Implicits #80

Merged

Conversation

juanpedromoreno
Copy link
Member

In order to simplify the use of frees-rpc, this PR makes that server and client implicits provide automatically:

  • import freestyle.implicits._
  • import freestyle.async.implicits._

Hence, users only need to import either:

  • import freestyle.rpc.client.implicits._
  • import freestyle.rpc.server.implicits._

@juanpedromoreno juanpedromoreno changed the title Async Implicits provided frees-rpc Implicits Async Implicits provided by frees-rpc Implicits Nov 9, 2017
Copy link
Contributor

@raulraja raulraja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this change would users still able to use?:

import freestyle.implicits._

or would the be forced to use the RPC ones?

@juanpedromoreno
Copy link
Member Author

The RPC ones would include import freestyle.implicits._.. I guess users couldn't use it in the standard way.. ambiguity perhaps?

What does make more sense?

@codecov-io
Copy link

codecov-io commented Nov 9, 2017

Codecov Report

Merging #80 into master will increase coverage by 0.81%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #80      +/-   ##
==========================================
+ Coverage   88.52%   89.34%   +0.81%     
==========================================
  Files          12       12              
  Lines         122      122              
==========================================
+ Hits          108      109       +1     
+ Misses         14       13       -1
Impacted Files Coverage Δ
rpc/src/main/scala/server/implicits.scala 100% <ø> (ø) ⬆️
rpc/src/main/scala/RPCAsyncImplicits.scala 80% <ø> (ø)
rpc/src/main/scala/internal/MonixAdapters.scala 84% <0%> (+4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1fa3448...b3aa3db. Read the comment docs.

@juanpedromoreno
Copy link
Member Author

Users could use the import freestyle.implicits._ if they are not using the Rpc ones.

@juanpedromoreno juanpedromoreno merged commit 4367723 into master Nov 10, 2017
@juanpedromoreno juanpedromoreno deleted the feature/async-implicits-provided-by-frees-rpc-implicits branch November 10, 2017 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants