Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sbt Modules Reorganization #900

Merged
merged 11 commits into from
May 4, 2020
Merged

Sbt Modules Reorganization #900

merged 11 commits into from
May 4, 2020

Conversation

juanpedromoreno
Copy link
Member

@juanpedromoreno juanpedromoreno commented May 3, 2020 •
edited
Loading

This PR makes all the changes according to this proposal. Thanks @cb372 .

Note: I'm not renaming/moving classes from its original logical package.

@juanpedromoreno
Combine the mu-common, mu-rpc-internal-core and mu-rpc-channel
da42cb1 
modules into a single module called mu-rpc-service. These modules are tightly coupled, either through dependency relationships or via references in macro-generated code, so we may as well combine them into one.
@juanpedromoreno
Combine the mu-health-check-unary, mu-rpc-fs2 and mu-rpc-monix modules
580d2e6 
into a single module called mu-health-check. This will contain both FS2 and Monix implementations, but it will declare dependencies with optional scope, so users only need to add a dependency on the streaming library they need. The grey arrows in the diagram indicate optional scope.
@juanpedromoreno
Rename mu-rpc-internal-{fs2,monix} to mu-rpc-{fs2,monix}
b0ebad9
@juanpedromoreno
Move all tests to a single tests module
f786e8e
@juanpedromoreno
Fixes test compilation issues
e998cb8
juanpedromoreno
juanpedromoreno commented May 3, 2020
View reviewed changes
build.sbt Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 3, 2020 •
edited
Loading

Codecov Report

Merging #900 into master will increase coverage by 0.45%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #900      +/-   ##
==========================================
+ Coverage   88.10%   88.55%   +0.45%     
==========================================
  Files          54       58       +4     
  Lines         807      830      +23     
  Branches        3        3              
==========================================
+ Hits          711      735      +24     
+ Misses         96       95       -1
Impacted Files Coverage Δ
...herkindness/mu/rpc/internal/client/fs2/calls.scala 83.33% <ø> (ø)
...kindness/mu/rpc/internal/server/fs2/handlers.scala 88.88% <ø> (ø)
...rpc/healthcheck/fs2/handler/HealthServiceFS2.scala 100.00% <ø> (ø)
...erkindness/mu/rpc/healthcheck/fs2/serviceFS2.scala 0.00% <ø> (ø)
...healthcheck/monix/handler/HealthServiceMonix.scala 100.00% <ø> (ø)
...ndness/mu/rpc/healthcheck/monix/serviceMonix.scala 0.00% <ø> (ø)
.../healthcheck/unary/handler/HealthServiceImpl.scala 100.00% <ø> (ø)
...erkindness/mu/rpc/healthcheck/unary/ordering.scala 100.00% <ø> (ø)
...herkindness/mu/rpc/healthcheck/unary/service.scala 0.00% <ø> (ø)
...higherkindness/mu/rpc/internal/MonixAdapters.scala 87.50% <ø> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b299ae8...2b04eb0. Read the comment docs.

@juanpedromoreno juanpedromoreno added the breaking-change A breaking change that needs to be treated with consideration label May 3, 2020
@juanpedromoreno juanpedromoreno marked this pull request as ready for review May 4, 2020 05:51
cb372
cb372 reviewed May 4, 2020
View reviewed changes
build.sbt Outdated Show resolved Hide resolved
@juanpedromoreno @cb372
Update build.sbt
57f47cb 
Co-authored-by: Chris Birchall <chris.birchall@47deg.com>
cb372
cb372 reviewed May 4, 2020
View reviewed changes
build.sbt Outdated Show resolved Hide resolved
cb372
cb372 reviewed May 4, 2020
View reviewed changes
build.sbt Outdated Show resolved Hide resolved
cb372
cb372 reviewed May 4, 2020
View reviewed changes
build.sbt Outdated Show resolved Hide resolved
cb372
cb372 reviewed May 4, 2020
View reviewed changes
build.sbt Outdated Show resolved Hide resolved
cb372
cb372 reviewed May 4, 2020
View reviewed changes
modules/tests/src/test/scala/higherkindness/mu/rpc/fs2/Utils.scala
@@ -21,7 +21,7 @@ import higherkindness.mu.rpc.common._
import higherkindness.mu.rpc.protocol._
import _root_.fs2._
import cats.effect.{Effect, IO, Resource}
import io.grpc.{CallOptions, Status}
import _root_.io.grpc.{CallOptions, Status}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this changed needed?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes

cb372
cb372 approved these changes May 4, 2020
View reviewed changes
Copy link
Member

@cb372 cb372 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@juanpedromoreno juanpedromoreno merged commit 0191f87 into master May 4, 2020
@juanpedromoreno juanpedromoreno deleted the jp/825-sbt-modules-reorganization branch May 4, 2020 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cb372 cb372 cb372 approved these changes

@fedefernandez fedefernandez fedefernandez approved these changes

Assignees
No one assigned
Labels
breaking-change A breaking change that needs to be treated with consideration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Major refactoring of the tests Audit and re-organise the sbt project structure
3 participants
@juanpedromoreno @cb372 @fedefernandez