-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sbt Modules Reorganization #900
Conversation
modules into a single module called mu-rpc-service. These modules are tightly coupled, either through dependency relationships or via references in macro-generated code, so we may as well combine them into one.
into a single module called mu-health-check. This will contain both FS2 and Monix implementations, but it will declare dependencies with optional scope, so users only need to add a dependency on the streaming library they need. The grey arrows in the diagram indicate optional scope.
Co-authored-by: Chris Birchall <chris.birchall@47deg.com>
@@ -21,7 +21,7 @@ import higherkindness.mu.rpc.common._ | |||
import higherkindness.mu.rpc.protocol._ | |||
import _root_.fs2._ | |||
import cats.effect.{Effect, IO, Resource} | |||
import io.grpc.{CallOptions, Status} | |||
import _root_.io.grpc.{CallOptions, Status} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this changed needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
This PR makes all the changes according to this proposal. Thanks @cb372 .
Note: I'm not renaming/moving classes from its original logical package.