Upgrade integration tests to Mu-Haskell v0.3 #920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the field is missing, fallback to the default value (`STARTED`). Most likely the field was not written to the wire because it had the default value.
We were trying to work with the FS2 stream after the client resource had been finalized, so the channel was already closed.
Some of the Avro tests are still failing, but a Mu-Haskell fix is on the way
and pin mu-haskell to a git commit for now
Codecov Report
@@ Coverage Diff @@
## master #920 +/- ##
==========================================
+ Coverage 88.58% 88.70% +0.12%
==========================================
Files 58 58
Lines 832 832
Branches 3 3
==========================================
+ Hits 737 738 +1
+ Misses 95 94 -1
Continue to review full report at Codecov.
|
juanpedromoreno
approved these changes
May 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does?
pending. All tests are now enabled and passing.stack.yaml, pin mu-haskell to a git commit (the currentHEADofmaster) for now, pending a release of v0.3.1 containing some bugfixes.I've rebuilt the
cb372/mu-haskell-warm-dot-stackandcb372/mu-scala-haskell-integration-testsDocker images on this branch and published them to Dockerhub.Checklist