Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ff/open api to mu #90

Merged
merged 3 commits into from May 22, 2019
Merged

Ff/open api to mu #90

merged 3 commits into from May 22, 2019

Conversation

BeniVF
Copy link
Contributor

@BeniVF BeniVF commented May 22, 2019

We are going to pospone the translation from Open Api to Mu, until we clarify the requirements.

In this pull request, I added the following features to the Open Api Spec:

  • Schemas inside Components.
  • Yaml support.

diesalbla
diesalbla approved these changes May 22, 2019
View reviewed changes
Copy link

@diesalbla diesalbla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the example files, or in a README next to them, we should include a note saying where we copied them from, and under which License.

src/test/scala/higherkindness/skeuomorph/openapi/OpenApiSchemaSpec.scala Show resolved Hide resolved
@BeniVF
Include NOTICE for the files copied from Open Api Spec.
1e49819 
Simplify the expression in examplesArbitrary.
pepegar
pepegar approved these changes May 22, 2019
View reviewed changes
Copy link
Member

@pepegar pepegar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @BeniVF !

@BeniVF BeniVF merged commit 5e976e2 into master May 22, 2019
@BeniVF BeniVF deleted the ff/open-api-to-mu branch May 22, 2019 13:48
This was referenced Jul 10, 2019
Merged
Merged
This was referenced Jul 30, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepegar pepegar pepegar approved these changes

@diesalbla diesalbla diesalbla approved these changes

@juanpedromoreno juanpedromoreno juanpedromoreno approved these changes

@vil1 vil1 Awaiting requested review from vil1

@peterneyens peterneyens Awaiting requested review from peterneyens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@BeniVF @pepegar @diesalbla @juanpedromoreno