Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open api parser #123

Merged
merged 2 commits into from Aug 1, 2019
Merged

Open api parser #123

merged 2 commits into from Aug 1, 2019

Conversation

BeniVF
Copy link
Contributor

@BeniVF BeniVF commented Aug 1, 2019

Objective

You can find, the objectives for all these PRs here: https://github.com/47deg/marlow/issues/188

Generating http4s client code based on a Open API specification using http4s v0.20 and 0.18 using circe to encode/decode.

Open Api Parser

It will require to create the Parser instances for yaml and json. This will simplify the use the library and it will be required for mu project. We can create an instance for json as following:

Parser[F, JsonSource, OpenApi[JsonSchemaF.Fixed]]

Avoid printing

There are some situation we should not print anything.

  • We should print empty string for models when the components / schemas they don't provide any schemas.
  • We should print empty string for interface / implementation when there are not paths defined.

Previous PRs

@BeniVF
Create the parsers for open api.
d0c3a48
@BeniVF
Make path optional for decoders.
7ea8554 
Avoid printing when there is not anything to print.
pepegar
pepegar approved these changes Aug 1, 2019
View reviewed changes
Copy link
Member

@pepegar pepegar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juanpedromoreno
juanpedromoreno approved these changes Aug 1, 2019
View reviewed changes
Copy link
Member

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@BeniVF BeniVF merged commit 9611d36 into master Aug 1, 2019
@BeniVF BeniVF deleted the open-api-parser branch August 1, 2019 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepegar pepegar pepegar approved these changes

@diesalbla diesalbla diesalbla approved these changes

@juanpedromoreno juanpedromoreno juanpedromoreno approved these changes

@noelmarkham noelmarkham Awaiting requested review from noelmarkham

@rafaparadela rafaparadela Awaiting requested review from rafaparadela

@peterneyens peterneyens Awaiting requested review from peterneyens

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@BeniVF @pepegar @diesalbla @juanpedromoreno