Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ff/print open api #97

Merged
merged 25 commits into from
Jun 25, 2019
Merged

Ff/print open api #97

merged 25 commits into from
Jun 25, 2019

Conversation

BeniVF
Copy link
Contributor

@BeniVF BeniVF commented Jun 17, 2019 •
edited
Loading

This PR contains the following features:

  • Supports the ammonite.
  • Generates the model based on #/components/schemas.
  • Generates trait with CRUD operations (POST, GET, PUT, _DELETE)
  • Supports a simple request/response model, it does not support multiple responses.
  • Generates circe encoder/decoder.
  • Generates http4s implementation with CRUD operations (POST, GET, PUT, _DELETE)
  • Supports http4s versions 0.20.x and 0.18.x

BeniVF added 20 commits June 5, 2019 11:52
@BeniVF
Add ammonite console.
653effa
@BeniVF
Print open api schema.
97b036f
@BeniVF
Print models based on Components (Open Api).
2ee0f36
@BeniVF
First approach client trait generation for Open Api.
26b4765 
Refactor test code.
@BeniVF
Add open api parameters.
40af1fe
@BeniVF
Support response types for open api in the code generation for traits.
7ab5356
@BeniVF
Print optional values and references with Open api.
e5a2057
@BeniVF
Generate response type when there are multiple options.
f2d3fd2
@BeniVF
First approach to implement client schema error for open api.
b7be855
@BeniVF
Print anonymous object in the response (open api).
65e4151
@BeniVF
Support print anonymous objects in success responses in open api.
debf5d6
@BeniVF
Support print simple response and response with anonymous objects in …
92ad238 
…Open Api.
@BeniVF
Implement print anonymous object in default responses open api.
edb23ee
@BeniVF
Refactor the code to make it more readable.
43542b3
@BeniVF
Use endpoint definition when operation id is not defined in Open Api.
093ce40
@BeniVF
Add import in the code generation for Open Api.
ef72e97
@BeniVF
First approach to generate http4s 0.20.x given an Open api spec.
9fdf1c9
@BeniVF
Print request parameter for open api.
c4abf44 
Rename and reuse imports printer.
Implement show printer.
Create specific types (TraitName, ImplName, OperationId).
@BeniVF
Print query parameters.
e7495d3 
Create HttpVerb and HttpPath types.
@BeniVF
Support http4s v0.18
1044801
noelmarkham
noelmarkham approved these changes Jun 18, 2019
View reviewed changes
Copy link
Contributor

@noelmarkham noelmarkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

juanpedromoreno
juanpedromoreno approved these changes Jun 20, 2019
View reviewed changes
Copy link
Member

@juanpedromoreno juanpedromoreno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! 👏

src/main/scala/higherkindness/skeuomorph/openapi/client/http4s/print.scala Outdated Show resolved Hide resolved
src/main/scala/higherkindness/skeuomorph/openapi/client/http4s/print.scala Outdated Show resolved Hide resolved
src/main/scala/higherkindness/skeuomorph/openapi/client/http4s/print.scala Show resolved Hide resolved
vil1
vil1 approved these changes Jun 21, 2019
View reviewed changes
Copy link
Contributor

@vil1 vil1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

pepegar
pepegar approved these changes Jun 21, 2019
View reviewed changes
Copy link
Member

@pepegar pepegar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

src/main/scala/higherkindness/skeuomorph/openapi/print.scala Show resolved Hide resolved
@BeniVF BeniVF merged commit 91bc256 into master Jun 25, 2019
@BeniVF BeniVF deleted the ff/print-open-api branch June 25, 2019 05:36
This was referenced Jul 10, 2019
Merged
Merged
This was referenced Jul 30, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pepegar pepegar pepegar approved these changes

@vil1 vil1 vil1 approved these changes

@noelmarkham noelmarkham noelmarkham approved these changes

@diesalbla diesalbla diesalbla approved these changes

@juanpedromoreno juanpedromoreno juanpedromoreno approved these changes

@peterneyens peterneyens Awaiting requested review from peterneyens

@fedefernandez fedefernandez Awaiting requested review from fedefernandez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@BeniVF @vil1 @pepegar @noelmarkham @diesalbla @juanpedromoreno