Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Javascript) Float32Array broken after 11.0.1 #3252

Closed
fserb opened this issue Jun 22, 2021 · 4 comments · Fixed by #3353
Closed

(Javascript) Float32Array broken after 11.0.1 #3252

fserb opened this issue Jun 22, 2021 · 4 comments · Fixed by #3353
Assignees
Labels
bug good first issue Should be easier for first time contributors help welcome Could use help from community language
Milestone

Comments

@fserb
Copy link

fserb commented Jun 22, 2021

Describe the issue

Float32Array is being broken in 3 token Float 32 and Array. This used to work fine on 10.7.3. Here is a side-by-side result jsfiddle.

Which language seems to have the issue?

javascript

Are you using highlight or highlightAuto?

highlightElement

Sample Code to Reproduce

new Float32Array();

also repros with more complicated lines, like const x = new Float32Array(3);.

Expected behavior

What used to happen on 10.7.3. Float32Array highlighted as a builtin.

Additional context

@fserb fserb added bug help welcome Could use help from community language labels Jun 22, 2021
@joshgoebel
Copy link
Member

joshgoebel commented Jun 22, 2021

This is indeed broken currently, although the new behavior may be to highlight this simply as a title.class rather than built-in. The CLASS_REFERENCE mode likely just needs to be expanded to proper recognize numbers and underscores in addition to letters.

@joshgoebel joshgoebel added the good first issue Should be easier for first time contributors label Jun 22, 2021
@fserb
Copy link
Author

fserb commented Jun 22, 2021

Makes sense. I'm fine with either way as long as it recognizes it as a single entity. :)

@rbrishabh
Copy link

I can help with this!

@joshgoebel
Copy link
Member

PR welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug good first issue Should be easier for first time contributors help welcome Could use help from community language
Projects
None yet
3 participants