Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move gdscript.js to root directory. #8

Closed
fengjiongmax opened this issue Oct 3, 2021 · 2 comments
Closed

move gdscript.js to root directory. #8

fengjiongmax opened this issue Oct 3, 2021 · 2 comments

Comments

@fengjiongmax
Copy link

Hello, I'm trying to make highlight.dart support GDScript, which has the language definition files generated from highlight.js.
However, unlike highlightjs-vue or highlightjs-graphql have the language definition files in the root directory, gdscript.js located in src/languages.
And I think it's also confusing having package.json's main value set to gdscript.js where there's no such file in the root directory.

@joshgoebel
Copy link
Member

The main key should be updated, src/languages is the correct location by convention.

@fengjiongmax
Copy link
Author

Following @joshgoebel 's instruction, I've created a PR.
And GDScript syntax definition file for highlight.dart can be generated from this repository, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants