Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

please increase versionCode #51

Open
IzzySoft opened this issue May 7, 2019 · 4 comments
Open

please increase versionCode #51

IzzySoft opened this issue May 7, 2019 · 4 comments

Comments

@IzzySoft
Copy link

IzzySoft commented May 7, 2019

versionCode seems still untouched – though v1.0.2 definitely isn't the first version, it's still set to 1:

package: name='marabillas.loremar.lmvideodownloader' versionCode='1' versionName='1.0.2' platformBuildVersionName=''

As that's how Android decides whether it's an update or not, could you please increase this number with each release? How much is up to you as long as the number is higher than it ever was before (you can use it as "release counter", or have it reflect the versionName ("major x 10000 + minor x 100 + patch"), whatever you prefer). Thanks!

@hikikomoriphoenix
Copy link
Owner

Thanks for letting me know, I will do so in the next update

@IzzySoft
Copy link
Author

IzzySoft commented May 7, 2019

Thanks! Then I can enable auto-updates 😃 And if you want to link to it: I've just added your app to my repo (updates will be fetched automatically within 24h of your adding a new tag and attaching the APK to it).

Besides, looks good by my library scanner – so if you wish, I could assist you getting your app listed in the official F-Droid repo, which only accepts fully-FOSS apps (which yours seems to be – unless I missed something, or there are 3rd party JARs needed to build it).

@hikikomoriphoenix
Copy link
Owner

Wow. That's so cool. Thanks!

Besides, looks good by my library scanner – so if you wish, I could assist you getting your app listed in the official F-Droid repo, which only accepts fully-FOSS apps (which yours seems to be – unless I missed something, or there are 3rd party JARs needed to build it).

I was planning to do so but I'd like to improve the app first before publishing it. The UI looks pretty bad and performance is also clunky.

@IzzySoft
Copy link
Author

IzzySoft commented May 8, 2019

Glad you like it – and thanks for polishing! (I cannot tell if that's needed as I'm not using the app myself – but quality improvement always sounds good 😄)

Ping me then if you need assistance getting it to F-Droid's official repo (disclosure: I'm one of the F-Droid maintainers).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants