fix: Hilo.getElementRect bug

hiloteam · May 18, 2016 · d1dda4a · d1dda4a
1 parent 17134c3
commit d1dda4a
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/src/core/Hilo.js b/src/core/Hilo.js
@@ -257,7 +257,7 @@ return {
             //this fails if it's a disconnected DOM node
             var bounds = elem.getBoundingClientRect();
         }catch(e){
-            bounds = {top:elem.offsetTop, left:elem.offsetLeft, width:elem.offsetWidth, height:elem.offsetHeight};
+            bounds = {top:elem.offsetTop, left:elem.offsetLeft, right:elem.offsetLeft + elem.offsetWidth, bottom:elem.offsetTop + elem.offsetHeight};
         }
 
         var offsetX = ((win.pageXOffset || docElem.scrollLeft) - (docElem.clientLeft || 0)) || 0;
@@ -269,14 +269,17 @@ return {
         var padTop = (parseIntFn(styles.paddingTop) + parseIntFn(styles.borderTopWidth)) || 0;
         var padRight = (parseIntFn(styles.paddingRight) + parseIntFn(styles.borderRightWidth)) || 0;
         var padBottom = (parseIntFn(styles.paddingBottom) + parseIntFn(styles.borderBottomWidth)) || 0;
+
         var top = bounds.top || 0;
         var left = bounds.left || 0;
+        var right = bounds.right || 0;
+        var bottom = bounds.bottom || 0;
 
         return {
             left: left + offsetX + padLeft,
             top: top + offsetY + padTop,
-            width: bounds.right - padRight - left - padLeft,
-            height: bounds.bottom - padBottom - top - padTop
+            width: right - padRight - left - padLeft,
+            height: bottom - padBottom - top - padTop
         };
     },